💄 Improve resizing for article thumbnails #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the image is resized to be 600px, which will work for most images but caused issues for images which have very wide aspect ratios. This change updates the partials to use a Fill with an appropriate bounding box, rather than a simple resize.
nunocoracao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the image is resized to be 600px, which will work for most images, but causes issues for images which have very wide aspect ratios. This change updates the partials to use a
Fillwith an appropriate bounding box, rather than a simple resize. The bounding box chosen roughly matches what the displayed aspect ratio ends up at.You can read more about Fill here.
To show an example, here's the current behavior for a wide image:
...and with this PR: