-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not suppress warning messages #294
base: v7.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Not sure why this warning was initially suppressed.
I'm working on a codebase with tons of tests, and my pipeline was consistently failing with a I'm not sure why this piece of code was being suppressed, but it should be fixed. |
I would also like to see this merged, it's affected by CI pipeline too and makes it very difficult to work out why CI is failing despite all tests passing. |
I am also waiting for this fix. I'm facing the same problem with CI piplene that falls without errors. And it also took a while to figure out the reason. The warning "No tests found in class" should not be suppressed. Until this is fixed, I have to use kludges. |
I would also like to see this merged. I'm aware the contributors have a lot of work, so I will be refreshing this page every week, to monitor progress. |
Any updates on this PR? I think suppressing messages that generate an exit code greater than 0 is not a good idea. |
Hi, thanks for the PR. I've tried to patch |
This is a fix for #293. Warnings should not be suppressed, unless you also suppress the output on
STDERR
.