Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not suppress warning messages #294

Open
wants to merge 1 commit into
base: v7.x
Choose a base branch
from

Conversation

selfsimilar
Copy link

This is a fix for #293. Warnings should not be suppressed, unless you also suppress the output on STDERR.

Copy link

@abobija abobija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Not sure why this warning was initially suppressed.

@hamidhaghdoost
Copy link

I'm working on a codebase with tons of tests, and my pipeline was consistently failing with a 1 exit code, without any error or warning. After a couple of days of debugging, I realized the issue: "A test file without implementation".

I'm not sure why this piece of code was being suppressed, but it should be fixed.

@edh649
Copy link

edh649 commented May 17, 2024

I would also like to see this merged, it's affected by CI pipeline too and makes it very difficult to work out why CI is failing despite all tests passing.

@yuraplohov
Copy link

I am also waiting for this fix. I'm facing the same problem with CI piplene that falls without errors. And it also took a while to figure out the reason. The warning "No tests found in class" should not be suppressed. Until this is fixed, I have to use kludges.

@jaymoh
Copy link

jaymoh commented Jul 25, 2024

I would also like to see this merged. I'm aware the contributors have a lot of work, so I will be refreshing this page every week, to monitor progress.

@Ghustavh97
Copy link

Any updates on this PR? I think suppressing messages that generate an exit code greater than 0 is not a good idea.

@darkbasic
Copy link

Hi, thanks for the PR. I've tried to patch DefaultPrinter.php but it still returns 1 with no warnings visible in the output. Any idea what might cause it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants