Prevent the runner to swallow its threads error

This should fix #609, or at least make the initial error bubble up allowing the user to fix it or report it properly
nunomaduro · Sep 28, 2023 · 77ba1c5 · 77ba1c5
1 parent 63e9d3f
commit 77ba1c5
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/src/Domain/Runner.php b/src/Domain/Runner.php
@@ -13,6 +13,7 @@
 use Symfony\Component\Console\Helper\ProgressBar;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Finder\SplFileInfo;
+use Symfony\Component\Process\Exception\ProcessFailedException;
 use Symfony\Component\Process\Process;
 
 /**
@@ -151,11 +152,17 @@ function (SplFileInfo $file): void {
 
         while ($runningProcesses !== []) {
             foreach ($runningProcesses as $i => $runningProcess) {
-                if (! $runningProcess->isRunning()) {
-                    $progressBar->advance(\count($filesByThread[$i]));
-                    unset($runningProcesses[$i]);
+                if ($runningProcess->isRunning()) {
+                    usleep(1000);
+                    continue;
                 }
-                usleep(1000);
+
+                if (!$runningProcess->isSuccessful()) {
+                    throw new ProcessFailedException($runningProcess);
+                }
+
+                $progressBar->advance(\count($filesByThread[$i]));
+                unset($runningProcesses[$i]);
             }
         }