add quotes around binary path #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElRochito
force-pushed
the
fix-binary-path
branch
from
17793a9
to
4799be5
Compare
|
@nunomaduro the suggested solution is right for you ? |
ElRochito
force-pushed
the
fix-binary-path
branch
from
0c746dc
to
b7a5fdc
Compare
ElRochito
force-pushed
the
fix-binary-path
branch
from
b7a5fdc
to
30a5a82
Compare
cmgmyr
requested changes
Sep 14, 2023
There was a problem hiding this comment.
@ElRochito thank you for your contribution, but unfortunately, the proposed solution will not work. The Str helper is only available when the dev dependencies are installed, which isn't always the case in production environments.
ElRochito
force-pushed
the
fix-binary-path
branch
from
92d6c91
to
01bc9d8
Compare
|
@cmgmyr indeed, I fixed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to escape binary path where php binary like this :
/Users/<username>/Library/Application Support/Herd/bin/php82We have a space between Application and Support and without quotes, Process stop at
/Users/<username>/Library/Applicationand can't find php executable