Two fixes to breakpoints and integration test #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #424 There were three issues: 1. There was a type error in the generated code, where the runtime system would check for the current line number in `$S.suspendRTS.linenum`, but the generated code would set the line number in `$__R.linenum`. JavaScript would silently create that field without blowing up. 2. Calling the `onBreakpoint` handler would not set the runtime's state to paused. (This is the error shown in #424). This is fixed and cleaned up a bit. 3. Unrelated error: we were instrumenting all blocks to support breakpoints, but not the top-level. The logic is identical and factored into a helper function in `suspendStep.ts`.
arjunguha
force-pushed
the
breakpoint-fixes
branch
from
67f0d70
to
bcf6e25
Compare
Securing Jenkins is a pain.
arjunguha
force-pushed
the
breakpoint-fixes
branch
from
bcf6e25
to
669061c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424
There were three issues:
There was a type error in the generated code, where the runtime
system would check for the current line number in
$S.suspendRTS.linenum, but the generated code would set the linenumber in
$__R.linenum. JavaScript would silently create that fieldwithout blowing up.
Calling the
onBreakpointhandler would not set the runtime's stateto paused. (This is the error shown in Polyfilled Array.sort with callback fails when a breakpoint is added. #424). This is fixed and
cleaned up a bit.
Unrelated error: we were instrumenting all blocks to support
breakpoints, but not the top-level. The logic is identical and
factored into a helper function in
suspendStep.ts.