Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two fixes to breakpoints and integration test #425

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Two fixes to breakpoints and integration test #425

merged 3 commits into from
Mar 15, 2019

Commits on Mar 15, 2019

  1. Two fixes to breakpoints and integration test 

    Fixes #424

There were three issues:

1. There was a type error in the generated code, where the runtime
   system would check for the current line number in
   `$S.suspendRTS.linenum`, but the generated code would set the line
   number in `$__R.linenum`. JavaScript would silently create that field
   without blowing up.

2. Calling the `onBreakpoint` handler would not set the runtime's state
   to paused. (This is the error shown in #424). This is fixed and
   cleaned up a bit.

3. Unrelated error: we were instrumenting all blocks to support
   breakpoints, but not the top-level. The logic is identical and
   factored into a helper function in `suspendStep.ts`.
    @arjunguha
    arjunguha committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    d1cd870 View commit details
    Browse the repository at this point in the history

  2. Back to Travis 

    Securing Jenkins is a pain.
    @arjunguha
    arjunguha committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    669061c View commit details
    Browse the repository at this point in the history

  3. Update release notes

    @arjunguha
    arjunguha committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    5870be2 View commit details
    Browse the repository at this point in the history