[T2A1][T01-T4]Lui Sheng Jie #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g(), implement removePrefixPhone & removePrefixEmail respectively
| @@ -54,7 +54,7 @@ | |||
| /** | |||
| * A platform independent line separator. | |||
| */ | |||
| private static final String LS = System.lineSeparator() + LINE_PREFIX; | |||
| private static final String LINE_SEPARATOR = System.lineSeparator() + LINE_PREFIX; | |||
There was a problem hiding this comment.
Good to see you change the variable name.
| * */ | ||
| private static final int INVALID_PROGRAM_ARGS = 2; | ||
| private static final int GIVEN_FILE_STORAGE_PROGRAM_ARGS = 1; | ||
| private static final int DEFAULT_FILE_STORAGE_PROGRAM_ARGS = 0; |
There was a problem hiding this comment.
Awesome, you remove the magic number and use good name to replace those constants .
| return removePrefixSign( | ||
| encoded.substring(indexOfPhonePrefix, indexOfEmailPrefix).trim(), | ||
| PERSON_DATA_PREFIX_PHONE); | ||
| return removePrefixPhone(encoded.substring(indexOfPhonePrefix, indexOfEmailPrefix).trim()); |
There was a problem hiding this comment.
The main goal of this activity is to change the removePrefixSign method. Please check the instruction again.
|
@luishengjie Some comments added. Please close the PR after reading comments. |
1 similar comment
|
@luishengjie Some comments added. Please close the PR after reading comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review