Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T4A2][T01-T1]Rahumathmarini #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[T4A2][T01-T1]Rahumathmarini #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/seedu/addressbook/data/tag/Tagging.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package seedu.addressbook.data.tag;

import java.util.ArrayList;

public class Tagging {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing header comment. All non-trivial classes/methods should have javadoc format header comments.

private ArrayList<String> addTag = new ArrayList<String>();
private ArrayList<String> deleteTag = new ArrayList<String>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recollect the discussion during tutorial on why this is not the right place to maintain the tagging list.
Please check and differentiate the 2 diagrams in the activity description for better understanding.


public ArrayList<String> getAddTag(){
return addTag;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation problem here? Our coding standard requires you to use 4 spaces instead of tabs. You can configure Eclipse to convert tabs to spaces automatically.

}

public ArrayList<String> getDeleteTag(){
return deleteTag;
}

public void addTag(String string){
addTag.add(string);
}

public void deleteTag(String string){
deleteTag.add(string);
}

}