Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[T3A3][T01-T04] Lui Sheng Jie #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[T3A3][T01-T04] Lui Sheng Jie #86

wants to merge 1 commit into from

Conversation

luishengjie
Copy link

Ready for review

@jeffryhartanto
Copy link

jeffryhartanto commented Jul 1, 2017 •
edited
Loading

@luishengjie
Some comments added. Please close the PR after reading comments.
I don't see any big issue regarding this PR. Good job. BTW, I can't see the setValue method. Also, you can use the super constructor to better remove some code in the child classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luishengjie @jeffryhartanto