[HusseinSafwan02] iP #463

HusseinSafwan02 · 2024-02-06T05:02:10Z

ChillChief

"Simplicity boils down to two steps: identify the essential, eliminate the rest."– Leo Babauta (source)

ChillChief is your go to assistant 'bro' for managing tasks in your life. It is

Super Chill
Super Easy
Super Useful

All you need to do is,

Download it from here.
Double-click it.
Add your tasks.
Let it manage your tasks for you 😉

And it is FREE

Features:

Add, Delete, and Find your tasks
Manage Deadlines, Events and Todo's
Receive Reminders (coming soon!)

If you are a Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }

Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature

Teeesa7

LGTM, just a tiny issue of unnecessary spaces at different places in the code.

Teeesa7 · 2024-02-08T07:38:15Z

src/main/java/Duke.java

 public class Duke {
+
+    // confirmation comment after adding a task
+    public static String addComment (Task task, int n) {


Shouln't there be no space following addComment and the arguments it takes in?

Teeesa7 · 2024-02-08T07:42:05Z

src/main/java/Duke.java

+        return message;
+    }
+
+    public static String introMessage() {


Perhaps another name for the method? Something like getIntroMessage()?, as introMessage() sounds like a String variable instead 😅

Teeesa7 · 2024-02-08T07:43:34Z

src/main/java/Duke.java

+        return greeting + mickey + intro;
+    }
+
+    public static String outroMessage() {


Please refer to the comment given for introMessage()

Teeesa7 · 2024-02-08T07:48:13Z

src/main/java/Deadline.java

@@ -0,0 +1,16 @@
+public class Deadline extends Task{


There should be a space after Task and { right? I noticed the same issue in other places, so just mind that :)

Teeesa7 · 2024-02-08T07:57:03Z

src/main/java/FileManager.java

+
+    private Task parseTask(String data) {
+        String[] parts = data.split(" \\| ");
+        if (parts.length < 3) return null; // Basic validation


Maybe you can use the K&R style brackets (Egyptian style) brackets here for better readability?

Li-Zizhen

Overall, your code is easy to understand. Most of your code follows the coding standard. However, there are some minor things you may fix. In all, LGTM, good job!

Li-Zizhen · 2024-02-12T14:41:44Z

src/main/java/Duke.java

+        return greeting + mickey + intro;
+    }
+
+    public static String outroMessage() {


Perhaps it's better to make the method name more understandable.

Li-Zizhen · 2024-02-12T14:42:53Z

src/main/java/Duke.java

+                        System.out.println(addComment(tasks.get(count - 1), count));
+                        fileManager.saveTasks(tasks);
+                    }
+


Not sure if this empty line is left on purpose or not.

Li-Zizhen · 2024-02-12T14:44:09Z

src/main/java/Event.java

+        return this.time;
+    }
+
+    @Override public String toString() {


Better to put Override above the method.

Li-Zizhen · 2024-02-12T14:48:34Z

src/main/java/Duke.java

+    public static void listTasks(ArrayList<Task> taskList, int count) {
+        System.out.print("____________________________________________________________\r\n");
+        System.out.println(" Here are the tasks in your list:");
+        for (int i = 0; i < taskList.size(); i++ ) {


Better to delete space after ++

Li-Zizhen · 2024-02-12T14:50:39Z

src/main/java/Duke.java

+        return message;
+    }
+
+    public static String replacer(String input) {


Better to use a verb for method naming.

Li-Zizhen · 2024-02-12T14:51:34Z

src/main/java/Duke.java

+
+

better not to leave so many empty lines.

Li-Zizhen · 2024-02-12T14:52:30Z

src/main/java/Duke.java

+                    if (isEvent) {
+                        String task = getTask(userInput);
+                        int index = userInput.indexOf("/");
+                        String when = replacer(userInput).substring(index);


Better use a noun to name variable.

Li-Zizhen · 2024-02-12T14:52:46Z

src/main/java/Duke.java

+                    }
+                    if (isDeadline) {
+                        int index = userInput.indexOf("/");
+                        String when = userInput.substring(index + 3);


same as above

Li-Zizhen · 2024-02-12T14:54:09Z

src/main/java/FileManager.java

+    }
+
+    private Task parseTask(String data) {
+        String[] parts = data.split(" \\| ");


Perhaps rename parts to something more understandable?

# Conflicts: # src/main/java/chillchief/ChillChief.java

A 'help' command is useful for new users who are using ChillChief for the first time. Let's, * update the parser to handle the 'help' command * update the TextUi to generate the text Ui for the user

No checking of important assumptions at various points in code. Checking of assumptions through assertions ensures that different points of the code is functioning as expected. Assertions added at key points with assumptions in private methods. Ensures arguments for private methods are valid.

Improved Code Quality

Assertions for important assumptions.

damithc and others added 16 commits January 7, 2024 18:33

docs/README.md: Tweak document template

55f9f9f

Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature

Add Gradle support

f837ddb

Bump gradle and lib version

a6f7324

Rename, Greet and Exit

8df1c58

Echo and "bye"

ad5e2fc

Added ability to store tasks

f8d1192

Tasks can be marked done

d75eb4e

Specific task types, dates

04a4a17

Automated Text-UI-Testing

daa138e

Handle Errors

41fc5ec

Support for deleting tasks

82a9029

Saving feature

1c6ae92

no message

7a3b9db

no message

02db0a2

clean up

7042639

Merge branch 'branch-level-7'

cc65365

Teeesa7 reviewed Feb 8, 2024

View reviewed changes

Li-Zizhen reviewed Feb 12, 2024

View reviewed changes

HusseinSafwan02 added 12 commits February 13, 2024 09:27

Dates and Times

0244700

Clean Up

0738ce5

Implemented TextUi class to manage messages

f7f3eb8

TaskList class to store/delete tasks

6f30956

Modification of tasks to handle own fileStrings

7fa16c6

Implemented toFileString() method for each task

d359971

Separated TextUi class to handle Ui

d80be04

TaskList class for encapsulation of tasklist

1cdfbd2

Finalised OOP structure

59675fa

Organised into packages

4fd360c

Implemented 'help' command

fc5c3ce

Merge branch 'add-gradle-support'

e8a09fb

HusseinSafwan02 and others added 29 commits February 22, 2024 01:34

Set up Gradle

1fed2bc

Unit testing for some non-trivial methods

6756461

updated build for JavaFX dependencies

c7e421f

Some Javdoc comments

9a5a6b6

Completed Javadoc comments.

df4309a

Followed coding standards

a0c4581

Implemented "find" functionality.

bbeda6d

no message

cb82d8f

Merge branch 'branch-Level-9'

04e99b3

Merge branch 'branch-A-CodingStandard'

d957267

Merge branch 'branch-A-JavaDoc'

1fb8970

# Conflicts: # src/main/java/chillchief/ChillChief.java

Merge branch 'branch-A-JavaDoc'

4e12621

no message

ad55edc

Coding standards

9293c12

Javadoc comments for all public methods

598d565

Implemented find feature

02df14e

'help' command: to allow users to learn a list of useful commands.

c85ad76

A 'help' command is useful for new users who are using ChillChief for the first time. Let's, * update the parser to handle the 'help' command * update the TextUi to generate the text Ui for the user

Improved Code Quality

fb0342e

Merge pull request #2 from HusseinSafwan02/branch-A-CodeQuality

c236f9a

Improved Code Quality

Merge pull request #3 from HusseinSafwan02/branch-A-Assertions

040b259

Assertions for important assumptions.

Implemented 'help' command and more friendly syntax

f090382

Update README.md

a4cbade

no message

5ec734f

No exception thrown from main method

ab3abbc

no message

a55c43a

no message

d6bbb30

Screenshot showing full GUI window

3904839

Finalized README

a5101a9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HusseinSafwan02] iP #463

[HusseinSafwan02] iP #463

HusseinSafwan02 commented Feb 6, 2024 •

edited

Loading

Teeesa7 left a comment

Teeesa7 Feb 8, 2024

Teeesa7 Feb 8, 2024

Teeesa7 Feb 8, 2024

Teeesa7 Feb 8, 2024

Teeesa7 Feb 8, 2024

Li-Zizhen left a comment

Li-Zizhen Feb 12, 2024

Li-Zizhen Feb 12, 2024

Li-Zizhen Feb 12, 2024

Li-Zizhen Feb 12, 2024

Li-Zizhen Feb 12, 2024

Li-Zizhen Feb 12, 2024

Li-Zizhen Feb 12, 2024

Li-Zizhen Feb 12, 2024

Li-Zizhen Feb 12, 2024

[HusseinSafwan02] iP #463

Are you sure you want to change the base?

[HusseinSafwan02] iP #463

Conversation

HusseinSafwan02 commented Feb 6, 2024 • edited Loading

ChillChief

Teeesa7 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Li-Zizhen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HusseinSafwan02 commented Feb 6, 2024 •

edited

Loading