[Zoebelle Pang] iP #470
[Zoebelle Pang] iP #470
Conversation
Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature
This reverts commit ce111a4.
There was a problem hiding this comment.
Hello there!👋
Great job overall. Most codes are in line with the Java Coding Standard and are easy to read.
Just minor inconsistencies with the Java Coding Standard need to be fixed. 🛠️
Keep up the good work! 💯
Also, I noticed that your Week 3's tasks are missing, please remember to push them if you have already completed them! If you have not done so, I wish you all the best! 💪✨
src/main/java/Duke.java
Outdated
| } | ||
|
|
||
| public void markAsDone() { | ||
| this.isDone = true; |
There was a problem hiding this comment.
Should the this keyword be used here? Perhaps you could refer to the Java Coding Standard under the variables section?
src/main/java/Duke.java
Outdated
| } | ||
|
|
||
| public void markAsUndone() { | ||
| this.isDone = false; |
There was a problem hiding this comment.
Similar to the previous comment, should the this keyword be used here?
src/main/java/Duke.java
Outdated
| return "[E]" + super.toString() + " (from: " + from + " to: " + to + ")"; | ||
| } | ||
| } | ||
|
|
||
| public class Duke { |
There was a problem hiding this comment.
Perhaps you could change the class name to your bot's name?
src/main/java/Duke.java
Outdated
|
|
||
| public Task(String taskDescription) { | ||
| this.taskDescription = taskDescription; | ||
| this.isDone = false; |
There was a problem hiding this comment.
I noticed the same issue in other places too.
src/main/java/Duke.java
Outdated
| if (userInput.equals("Bye")) { | ||
| System.out.println("Bye. Hope to see you again soon!"); | ||
| break; | ||
| } else if (userInput.equals("List")) { | ||
|
|
||
| for (int i = 0; i < tasks.size(); i++) { | ||
| System.out.println((i + 1) + ". " + tasks.get(i)); | ||
| } | ||
|
|
||
| } else if (userInput.startsWith("todo")) { |
There was a problem hiding this comment.
I have only highlighted a small portion but good job on using K&R style brackets (aka Egyptian style) throughout your code.
src/main/java/Duke.java
Outdated
| for (int i = 0; i < tasks.size(); i++) { | ||
| System.out.println((i + 1) + ". " + tasks.get(i)); |
There was a problem hiding this comment.
I liked how you have added white spaces within the statements according to the Java Coding Standard.
src/main/java/Duke.java
Outdated
| } | ||
|
|
||
| public String toString() { | ||
| return "[" + (isDone ? "X" : " ") + "] " + taskDescription; |
src/main/java/Duke.java
Outdated
There was a problem hiding this comment.
perhaps it should be while the input is not equal to "bye", rather than while(true)?
This reverts commit 9ed10ba.
This reverts commit db2313f.
…g for status tracking Enhance file open handling in the Storage class to provide better feedback and prevent potential issues. Introduce a boolean flag, fileIsOpen, to track the status of the file. Step forward, utilize assert statements in Duke class to ensure file openness before processing user input.
Branch a assertions
This reverts commit eef2934.
Branch a code quality
C-DetectDuplicates Detect duplicate in todo tasks
# Conflicts: # data/duke.txt
This reverts commit 0840c85.
Bentley
The background color is
#fffffffor light mode and#000000for dark mode.#0969DA"Your mind is for having ideas, not holding them." – David Allen (source)
DukePro frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
README guidelines for this project
And it is FREE!
Features:
Some input commands are:
Note
Use clear and detailed task outlines to improve how you handle your tasks. It's easier to find jobs and keep things organised in Bentley when details are clear.
Click here to visit GitHub and see some
inline code.