-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jinyan] iP #554
Open
Morninggloryyy
wants to merge
65
commits into
nus-cs2103-AY2324S2:master
Choose a base branch
from
Morninggloryyy:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Jinyan] iP #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature
… the user types the command bye.
…wList, stop, mark, unmark), added a new class (Task).
… of tasks (ToDos, Events, Deadlines)
…ing). Used the input/output redirection technique to semi-automate the testing of Damon.
# Conflicts: # src/main/java/damon/command/AddCommand.java # src/main/java/damon/tasklist/TaskList.java # src/main/java/damon/ui/Ui.java
There is no showWelcome() method in Response object and there is no need to have a function showing welcome message in Damon constructer method. So, response.showWelcome() has been deleted from Damon constructer method.
Modify code (e.g., add new comments, change import statements format) to further improve code quality. Now, codes follow closely the 'Code Quality' topics.
Branch a assertions
Update damon.Dmon.java, damon.Launcher.java, damon.command package, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Damon
Damon frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
And it is 100% FREE!
Features:
Use
list
command to list all Tasks in your task list 😉Note
Please follow the input format carefully!
If you are a Java programmer, you can use it to practice Java too. Here's the main method: