Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yu-sutong] iP #644

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Commits on Jul 11, 2024

  1. Add Gradle support

    damithc authored and damithc committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    68c58c1 View commit details
    Browse the repository at this point in the history
  2. Bump gradle and lib version

    Eclipse-Dominator authored and damithc committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    03523ec View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. build.gradle: Prevent generating a second JAR file

    In build.gradle, the dependencies on distZip and/or distTar causes
    the shadowJar task to generate a second JAR file for which the
    mainClass.set("seedu.duke.Duke") does not take effect.
    Hence, this additional JAR file cannot be run.
    For this product, there is no need to generate a second JAR file
    to begin with.
    
    Let's remove this dependency from the build.gradle to prevent the
    shadowJar task from generating the extra JAR file.
    aureliony authored and damithc committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    81a9c53 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. add MySutong.java

    yu-sutong committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2444f9f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    63c5161 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f6f0834 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    22d5127 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    03c23f1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5cc42a8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    48d1228 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9f681ef View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Add Level 7 save feature

    yu-sutong committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6227710 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d671ee6 View commit details
    Browse the repository at this point in the history
  3. Add Level 8 features

    yu-sutong committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e5faf70 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e9c381b View commit details
    Browse the repository at this point in the history
  5. Add A-MoreOOP increments

    yu-sutong committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    42a5567 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    75357a1 View commit details
    Browse the repository at this point in the history
  7. Add A-Packages increments

    yu-sutong committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6904425 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    64bc665 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    088c231 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Add A-JUnit increments

    yu-sutong committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    00682ea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7291aae View commit details
    Browse the repository at this point in the history
  3. Add A-Jar increments

    yu-sutong committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    099842b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    452885a View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Make the code follow OOP

    yu-sutong committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    c7e40e7 View commit details
    Browse the repository at this point in the history
  2. Add A-JavaDoc increments

    yu-sutong committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    dbe8c9d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f5ff5e5 View commit details
    Browse the repository at this point in the history
  4. Add Level-9 increments

    yu-sutong committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    96b7f19 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0c93397 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'branch-A-CodingStandard'

    # Conflicts:
    #	src/main/java/mysutong/Storage.java
    yu-sutong committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    b8588bb View commit details
    Browse the repository at this point in the history
  7. Merge branch 'branch-Level-9'

    # Conflicts:
    #	src/main/java/mysutong/Parser.java
    #	src/main/java/mysutong/Ui.java
    yu-sutong committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    cb865f8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    93a4976 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Make it more OOP

    yu-sutong committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6fb2994 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Add Level 10 increments

    yu-sutong committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    04e7aec View commit details
    Browse the repository at this point in the history
  2. Make it more OOP

    yu-sutong committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    91fda45 View commit details
    Browse the repository at this point in the history
  3. Add JavaDoc to classes

    yu-sutong committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f9f94b1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b9dd928 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Add assertion to ensure valid command input

    The executeCommand method in Parser handles user commands by splitting the input string into two parts: the command itself and any additional arguments.
    
    Currently, the split operation does not validate that the input string contains at least one element, which could potentially lead to unexpected behaviour or bugs if empty input is passed.
    
    To mitigate this, let's add an assert statement to ensure that the inputs array has at least one element. This ensures that the code always receives a valid command to process. In situations where assertions are enabled, this will help catch empty or invalid commands during development and testing.
    
    While this doesn't address user input validation directly (since assert can be disabled in production), it adds an extra layer of safety during development.
    
    This change also avoids unnecessary array access errors and improves the stability of the command handling logic.
    yu-sutong committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c0a7a97 View commit details
    Browse the repository at this point in the history
  2. Refactor code style to adhere to Checkstyle guidelines

    This commit refactors the code to conform to the Checkstyle configuration, ensuring consistency and compliance with coding standards.
    
    Changes made:
    - Replaced wildcard imports (e.g., import static org.junit.jupiter.api.Assertions.*) with explicit imports for better clarity and to avoid unnecessary imports.
    - Corrected import order to follow the standard conventions, ensuring that java.* imports are grouped together and listed alphabetically.
    - Fixed spacing issues, such as ensuring a single space between comments and code, and after operators (e.g., =, +).
    - Improved overall code readability and conformance to Checkstyle rules by addressing minor formatting inconsistencies.
    
    These changes are intended to improve the maintainability of the codebase by ensuring that it follows consistent styling rules as enforced by Checkstyle. By doing this, we minimize the chances of formatting-related errors and enhance code readability across the project.
    
    All changes are purely stylistic and do not alter the functionality of the code.
    yu-sutong committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    77f1525 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2 from yu-sutong/branch-A-Assertions

    Add assertion to ensure valid command input
    yu-sutong authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ac4ead8 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #3 from yu-sutong/branch-A-CodeQuality

    Refactor code style to adhere to Checkstyle guidelines
    yu-sutong authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4f463f0 View commit details
    Browse the repository at this point in the history
  5. Implement C-Priority

    yu-sutong committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    337907c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4bb5af2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0ba740e View commit details
    Browse the repository at this point in the history
  8. Edit README.md

    yu-sutong committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4936b86 View commit details
    Browse the repository at this point in the history