-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yu-sutong] iP #644
base: master
Are you sure you want to change the base?
[yu-sutong] iP #644
Commits on Jul 11, 2024
-
damithc authored and damithc committed
Jul 11, 2024 Configuration menu - View commit details
-
Copy full SHA for 68c58c1 - Browse repository at this point
Copy the full SHA 68c58c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03523ec - Browse repository at this point
Copy the full SHA 03523ecView commit details
Commits on Jul 21, 2024
-
build.gradle: Prevent generating a second JAR file
In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.
Configuration menu - View commit details
-
Copy full SHA for 81a9c53 - Browse repository at this point
Copy the full SHA 81a9c53View commit details
Commits on Aug 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2444f9f - Browse repository at this point
Copy the full SHA 2444f9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63c5161 - Browse repository at this point
Copy the full SHA 63c5161View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6f0834 - Browse repository at this point
Copy the full SHA f6f0834View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22d5127 - Browse repository at this point
Copy the full SHA 22d5127View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03c23f1 - Browse repository at this point
Copy the full SHA 03c23f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cc42a8 - Browse repository at this point
Copy the full SHA 5cc42a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48d1228 - Browse repository at this point
Copy the full SHA 48d1228View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f681ef - Browse repository at this point
Copy the full SHA 9f681efView commit details
Commits on Sep 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6227710 - Browse repository at this point
Copy the full SHA 6227710View commit details -
Configuration menu - View commit details
-
Copy full SHA for d671ee6 - Browse repository at this point
Copy the full SHA d671ee6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5faf70 - Browse repository at this point
Copy the full SHA e5faf70View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9c381b - Browse repository at this point
Copy the full SHA e9c381bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42a5567 - Browse repository at this point
Copy the full SHA 42a5567View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75357a1 - Browse repository at this point
Copy the full SHA 75357a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6904425 - Browse repository at this point
Copy the full SHA 6904425View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64bc665 - Browse repository at this point
Copy the full SHA 64bc665View commit details -
Configuration menu - View commit details
-
Copy full SHA for 088c231 - Browse repository at this point
Copy the full SHA 088c231View commit details
Commits on Sep 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 00682ea - Browse repository at this point
Copy the full SHA 00682eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7291aae - Browse repository at this point
Copy the full SHA 7291aaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 099842b - Browse repository at this point
Copy the full SHA 099842bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 452885a - Browse repository at this point
Copy the full SHA 452885aView commit details
Commits on Sep 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c7e40e7 - Browse repository at this point
Copy the full SHA c7e40e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbe8c9d - Browse repository at this point
Copy the full SHA dbe8c9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5ff5e5 - Browse repository at this point
Copy the full SHA f5ff5e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96b7f19 - Browse repository at this point
Copy the full SHA 96b7f19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c93397 - Browse repository at this point
Copy the full SHA 0c93397View commit details -
Merge branch 'branch-A-CodingStandard'
# Conflicts: # src/main/java/mysutong/Storage.java
Configuration menu - View commit details
-
Copy full SHA for b8588bb - Browse repository at this point
Copy the full SHA b8588bbView commit details -
# Conflicts: # src/main/java/mysutong/Parser.java # src/main/java/mysutong/Ui.java
Configuration menu - View commit details
-
Copy full SHA for cb865f8 - Browse repository at this point
Copy the full SHA cb865f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93a4976 - Browse repository at this point
Copy the full SHA 93a4976View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6fb2994 - Browse repository at this point
Copy the full SHA 6fb2994View commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 04e7aec - Browse repository at this point
Copy the full SHA 04e7aecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91fda45 - Browse repository at this point
Copy the full SHA 91fda45View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9f94b1 - Browse repository at this point
Copy the full SHA f9f94b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9dd928 - Browse repository at this point
Copy the full SHA b9dd928View commit details
Commits on Sep 23, 2024
-
Add assertion to ensure valid command input
The executeCommand method in Parser handles user commands by splitting the input string into two parts: the command itself and any additional arguments. Currently, the split operation does not validate that the input string contains at least one element, which could potentially lead to unexpected behaviour or bugs if empty input is passed. To mitigate this, let's add an assert statement to ensure that the inputs array has at least one element. This ensures that the code always receives a valid command to process. In situations where assertions are enabled, this will help catch empty or invalid commands during development and testing. While this doesn't address user input validation directly (since assert can be disabled in production), it adds an extra layer of safety during development. This change also avoids unnecessary array access errors and improves the stability of the command handling logic.
Configuration menu - View commit details
-
Copy full SHA for c0a7a97 - Browse repository at this point
Copy the full SHA c0a7a97View commit details -
Refactor code style to adhere to Checkstyle guidelines
This commit refactors the code to conform to the Checkstyle configuration, ensuring consistency and compliance with coding standards. Changes made: - Replaced wildcard imports (e.g., import static org.junit.jupiter.api.Assertions.*) with explicit imports for better clarity and to avoid unnecessary imports. - Corrected import order to follow the standard conventions, ensuring that java.* imports are grouped together and listed alphabetically. - Fixed spacing issues, such as ensuring a single space between comments and code, and after operators (e.g., =, +). - Improved overall code readability and conformance to Checkstyle rules by addressing minor formatting inconsistencies. These changes are intended to improve the maintainability of the codebase by ensuring that it follows consistent styling rules as enforced by Checkstyle. By doing this, we minimize the chances of formatting-related errors and enhance code readability across the project. All changes are purely stylistic and do not alter the functionality of the code.
Configuration menu - View commit details
-
Copy full SHA for 77f1525 - Browse repository at this point
Copy the full SHA 77f1525View commit details -
Merge pull request #2 from yu-sutong/branch-A-Assertions
Add assertion to ensure valid command input
Configuration menu - View commit details
-
Copy full SHA for ac4ead8 - Browse repository at this point
Copy the full SHA ac4ead8View commit details -
Merge pull request #3 from yu-sutong/branch-A-CodeQuality
Refactor code style to adhere to Checkstyle guidelines
Configuration menu - View commit details
-
Copy full SHA for 4f463f0 - Browse repository at this point
Copy the full SHA 4f463f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 337907c - Browse repository at this point
Copy the full SHA 337907cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bb5af2 - Browse repository at this point
Copy the full SHA 4bb5af2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ba740e - Browse repository at this point
Copy the full SHA 0ba740eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4936b86 - Browse repository at this point
Copy the full SHA 4936b86View commit details