Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event Picture PDFs #270

Closed
Sean-Tay opened this issue Apr 2, 2017 · 1 comment
Closed

Event Picture PDFs #270

Sean-Tay opened this issue Apr 2, 2017 · 1 comment
Assignees
@ycewe @Vylantze @Muhammad-Adam
Labels
bug UI

Comments

@Sean-Tay
Copy link
Contributor

Sean-Tay commented Apr 2, 2017 •
edited
Loading

Some Events use PDFs as a Poster, which causes the Image Previewer to break.

Would this work:
<embed src="http://example.com/the.pdf" width="500" height="375" type='application/pdf'>
@ycewe ycewe mentioned this issue Apr 2, 2017
Merged
Sean-Tay added a commit that referenced this issue Apr 2, 2017
@Sean-Tay
Merge pull request #273 from nus-mtp/#270_event_picture_pdfs
44b003e 
#270 Event Picture Pdfs
@Sean-Tay Sean-Tay closed this as completed Apr 2, 2017
@Sean-Tay Sean-Tay reopened this Apr 3, 2017
@Sean-Tay Sean-Tay added bug and removed low-priority labels Apr 3, 2017
@Sean-Tay
Copy link
Contributor Author

Sean-Tay commented Apr 3, 2017

The PDF Previewer doesn't work on the Heroku deployment.

@Sean-Tay Sean-Tay closed this as completed Apr 3, 2017
@Sean-Tay Sean-Tay reopened this Apr 3, 2017
@ycewe ycewe closed this as completed Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ycewe ycewe

@Vylantze Vylantze

@Muhammad-Adam Muhammad-Adam

Labels
bug UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ycewe @Vylantze @Muhammad-Adam @Sean-Tay