#198 fix exhibition references #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and comment.js.
… with the _ids of the Event and Exhibitions instead.
…y - leading to more Exhibition Documents being inserted than necessary.
…e and Exhibition schema properties.
Removed redundant paramater of attendance_type when looking for unique identifer. Removed searchAttendanceByNameAndType method as it is no longer relevant. Renamed methods from Name to Key.
Changed 2 test data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts of our previous implementation assumed that the exhibition_name attribute under each Exhibition Document was unique. This is not the case.
Instead, either the Exhibition ID itself, or the Exhibition's exhibition_name and the Exhibition's event_name should be used as a unique identifier. Affected Schemas and ObjectClasses include: