Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#254 remove remote database credentials #255

Merged
merged 19 commits into from
Apr 1, 2017

Conversation

Sean-Tay
Copy link
Contributor

@Sean-Tay Sean-Tay commented Mar 31, 2017

  1. Phased out the use of config.json for accessing DB parameters, and subsequently removed the usage of currentdb.js - now they all use environment variables - to be set externally, either in the gulp configuration file or in the heroku deployment itself.
  2. Added gulp tasks for running activeStepsConverterScript and fullStepsConverterScript:
    'gulp active-convert' or 'gulp full-convert'

Sean-Tay added 19 commits March 31, 2017 22:14
…p into username, password, host, port, database name.
…, only during gulp test.

Updated tests to use the TEST_DB environment variable.
…d DEST db.

2) The converter scripts now export a function, rather than being a runnable file.
2) Removed database credentials from config.json.
3) Made middleware use global database connection.
@Sean-Tay Sean-Tay self-assigned this Mar 31, 2017
@Sean-Tay Sean-Tay mentioned this pull request Apr 1, 2017
@ycewe ycewe merged commit 5fb36cf into develop Apr 1, 2017
@ycewe ycewe deleted the #254_Remove_Remote_Database_Credentials branch April 1, 2017 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants