Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#338 Create 404 Page #346

Merged
merged 16 commits into from
Apr 11, 2017
Merged

#338 Create 404 Page #346

merged 16 commits into from
Apr 11, 2017

Conversation

ycewe
Copy link
Contributor

@ycewe ycewe commented Apr 11, 2017

Closes #338

Features:

  1. Invalid exhibitions leads to 404
  2. Invalid events leads to 404
  3. Invalid profile leads to 404
  4. Invalid pages leads to 404
  5. Login, Logout and Register no longer has search bar
  6. Home-icon has max width and is constrained to the left

@ycewe ycewe self-assigned this Apr 11, 2017
@Muhammad-Adam
Copy link
Contributor

error

Home icon is partly blocked by search box.

@ycewe
Copy link
Contributor Author

ycewe commented Apr 11, 2017

@adam issue resolved. Please review.

@Muhammad-Adam Muhammad-Adam merged commit 07b14c7 into develop Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Muhammad-Adam Muhammad-Adam Muhammad-Adam approved these changes

@Vylantze Vylantze Awaiting requested review from Vylantze

@Sean-Tay Sean-Tay Awaiting requested review from Sean-Tay

@JeanKoh JeanKoh Awaiting requested review from JeanKoh

Assignees

@ycewe ycewe

Labels
high-priority UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ycewe @Muhammad-Adam