Add ResNet and QA models. Created Qestion_Answering folder under examples/models #5
Conversation
|
fix #4 |
|
@delphieritas May you also add this file here, thanks https://github.com/easyfan327/rafiki_panda_dev/blob/panda-dev/examples/models/image_classification/inception.py |
|
|
||
| class PyPandaQA(PandaTorchBasicModel): | ||
| """ | ||
| Implementation of PyTorch Vgg |
There was a problem hiding this comment.
it is not vgg, may change the comment
|
|
||
| return best_answer, confidence, best_paragraph | ||
|
|
||
| class PyPandaQA(PandaTorchBasicModel): |
There was a problem hiding this comment.
PandaTorchBasicModel was renamed to TorchModel
There was a problem hiding this comment.
you can see the renamed class https://github.com/nusdbsystem/singa-easy/blob/master/singa_easy/models/TorchModel.py#L74
|
|
||
|
|
||
|
|
||
| class PyPandaResNet(PandaTorchBasicModel): |
There was a problem hiding this comment.
PandaTorchBasicModel was renamed to TorchModel
There was a problem hiding this comment.
you can see the renamed class https://github.com/nusdbsystem/singa-easy/blob/master/singa_easy/models/TorchModel.py#L74
no. I suggest to create a separate PR for each model instead of combining many models in a single PR. It becomes difficult to review and merge. |
@delphieritas Please submit the panda model of resnet and inception in other PRs, thanks |
QA model might still be tuning in the future