Allow dereferencing AnsiString as underlying string #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've been in process of converting https://github.com/ogham/exa from
rust-ansi-term
tonu-ansi-term
and there is one api that exa needs that was lost during the refactoring from rust-ansi-term to nu-ansi-term.exa
needs the underlying raw string to calculate widths, previously this api was present in a form, where AnsiString could be dereferenced intoCow<'a, str>
, directly and the to str, which was then used.This adds the minimal required code, it just returns
&str
which is the minimum needed.I tried to workaround this with some other api but could not found any in
nu-ansi-term
andto_string
would require allocation which seemed unnecessary as the underlying view can be returned directly.