Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test crate with all features enabled in the build job #26

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Test crate with all features enabled in the build job #26

merged 1 commit into from
Mar 8, 2023

Conversation

nickelc
Copy link

@nickelc nickelc commented Mar 8, 2023

No description provided.

@sholderbach
Copy link
Member

The tests here are cheap, so could be worth testing the whole feature matrix.

@nickelc
Copy link
Author

nickelc commented Mar 8, 2023

I don't know. It's just one additive feature.

@sholderbach
Copy link
Member

Also true that the likelihood of a serde derive breaking something should be minor.

@sholderbach sholderbach merged commit 9e85aa5 into nushell:main Mar 8, 2023
@nickelc nickelc deleted the ci-serde branch March 8, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants