-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow installing multiple modules from a single package #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amtoine
changed the title
Allow 'modules' field in packages.nuon
allow installing multiple modules from a single package
Oct 16, 2023
|
amtoine
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's roll with this and mainly try to fix nu_scripts
🙏
thanks @kubouch 🥳
This was referenced Oct 19, 2023
Merged
amtoine
added a commit
to nushell/nu_scripts
that referenced
this pull request
Oct 23, 2023
related to - nushell/nupm#33 ## description with nushell/nupm#33, Nupm can now install separate modules from a single package 🥳 the `nu_scripts` are a package and looks like they contain a few potential standalone modules: - the themes - the hooks - the custom completions - ... this PR is a proposal to move `themes/` to `nu-themes/` and add `./nu-themes/` as a module to the `nu-scripts` package. that way when running `nupm install --path .` in the root of the `nu_scripts`, a `nu-themes` module will be installed in `$env.NUPM_HOME/modules`. then one can run ```nushell use nu-themes/themes/nushell-dark.nu ``` and next get the theme with ```nushell nushell-dark ```
2 tasks
kubouch
pushed a commit
that referenced
this pull request
Dec 13, 2023
maxim-uvarov
pushed a commit
to maxim-uvarov/nu_scripts_reduced_size
that referenced
this pull request
Oct 12, 2024
related to - nushell/nupm#33 ## description with nushell/nupm#33, Nupm can now install separate modules from a single package 🥳 the `nu_scripts` are a package and looks like they contain a few potential standalone modules: - the themes - the hooks - the custom completions - ... this PR is a proposal to move `themes/` to `nu-themes/` and add `./nu-themes/` as a module to the `nu-scripts` package. that way when running `nupm install --path .` in the root of the `nu_scripts`, a `nu-themes` module will be installed in `$env.NUPM_HOME/modules`. then one can run ```nushell use nu-themes/themes/nushell-dark.nu ``` and next get the theme with ```nushell nushell-dark ```
maxim-uvarov
pushed a commit
to maxim-uvarov/nu_scripts_reduced_size
that referenced
this pull request
Oct 13, 2024
related to - nushell/nupm#33 ## description with nushell/nupm#33, Nupm can now install separate modules from a single package 🥳 the `nu_scripts` are a package and looks like they contain a few potential standalone modules: - the themes - the hooks - the custom completions - ... this PR is a proposal to move `themes/` to `nu-themes/` and add `./nu-themes/` as a module to the `nu-scripts` package. that way when running `nupm install --path .` in the root of the `nu_scripts`, a `nu-themes` module will be installed in `$env.NUPM_HOME/modules`. then one can run ```nushell use nu-themes/themes/nushell-dark.nu ``` and next get the theme with ```nushell nushell-dark ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to
this will supersede #28
Description
Adds support for
$.modules
field to package.nuon. Similar to$.scripts
, this allows installing modules (both files and directories) from custom locations.Another change is that the default package module (
package-name/
dir) and script (package-name.nu
file) are not required. You can have a package that has only the$.modules:
and$.scripts:
fields in package.nuon.