Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put Starship integration forward in prompt chapter #1131

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Oct 29, 2023

related to

description

i found someone confused about the snippet in the Starship part of How to configure 3rd party prompts not working and giving the following error

error: unexpected argument '-1' found

Usage: starship prompt [OPTIONS]

For more information, try '--help'.

NOTE:
    passed arguments: ["prompt", "--cmd-duration", "276668", "--status", "-1"]

when pressing ctrl-c.

i'm using the official integration with Starship and i've never seen that kind of error.

in this PR, i propose to put the official integration with Starship forward by moving its mention above the snippet, in a TIP 😌

@fdncred
Copy link
Collaborator

fdncred commented Oct 29, 2023

ok, seems right to me.

@fdncred fdncred merged commit 31302b3 into nushell:main Oct 29, 2023
2 checks passed
@amtoine amtoine deleted the put-starship-integration-forward branch October 29, 2023 17:37
@amtoine
Copy link
Member Author

amtoine commented Oct 29, 2023

did not realize i commited "foo" 👀 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants