Skip to content

Conversation

ghaaj
Copy link
Contributor

@ghaaj ghaaj commented Sep 27, 2024

This PR unifies the language identifiers of the code blocks for installation commands to 'sh'.
Syntax highlighting will be applied to the modified code blocks, and the extra $ sign at the beginning will be removed when copied.

@fdncred
Copy link
Contributor

fdncred commented Sep 27, 2024

I'm not sure this is a good change because this is a windows only section and probably no one on windows is running sh but it is likely they're running powershell.

@ghaaj
Copy link
Contributor Author

ghaaj commented Sep 28, 2024

Thank you for reviewing. Would the preferred choice then be to keep the language identifier of the powershell section as is and delete the $ sign?

@fdncred
Copy link
Contributor

fdncred commented Sep 28, 2024

ya, good idea

@fdncred fdncred merged commit 1dae0c3 into nushell:main Sep 29, 2024
2 checks passed
@fdncred
Copy link
Contributor

fdncred commented Sep 29, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants