Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix Android table issues #1580

Closed
wants to merge 3 commits into from

Conversation

NotTheDr01ds
Copy link
Contributor

@NotTheDr01ds NotTheDr01ds commented Oct 6, 2024

As @132ikl mentioned in Discord today, the latest update breaks formatting on tables in code-blocks on Android browsers. This looks like it is due to a change where the --font-family-codes got split across multiple lines, which should be invalid. This puts them back on one line and will hopefully fix the issue.

@NotTheDr01ds
Copy link
Contributor Author

Err, didn't get committed. Will fix when I get back to keyboard.

@NotTheDr01ds NotTheDr01ds marked this pull request as draft October 6, 2024 17:06
@NotTheDr01ds
Copy link
Contributor Author

Looks like Prettier was reformatting stylesheets. Added them to the .prettierignore to keep them from getting reformatted.

@NotTheDr01ds NotTheDr01ds marked this pull request as ready for review October 6, 2024 21:33
@132ikl
Copy link
Contributor

132ikl commented Oct 6, 2024

Still have the issue on Android with this PR :(

@NotTheDr01ds NotTheDr01ds marked this pull request as draft October 6, 2024 23:02
@NotTheDr01ds
Copy link
Contributor Author

@132ikl Ah, you beat me to it. I was just coming over here to move it back to draft since it doesn't work for me either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants