Skip to content

Apply theme change only for ansi highlights #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

132ikl
Copy link
Member

@132ikl 132ikl commented Dec 28, 2024

Use the one-dark-pro theme only for ansi code blocks. Additionally, override the background color to be the same as dark-plus.

I can switch the theme if others would prefer, but I think the one-dark-pro theme looks decent along with the other code blocks, and is very readable. Here's an error using ansi, highlighted with one-dark-pro:

image

@fdncred
Copy link
Contributor

fdncred commented Dec 28, 2024

Let's try it out and see if we like it.

@fdncred fdncred merged commit afdb440 into nushell:main Dec 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants