Add missing code font var #1907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code blocks use a different variable, which this commit adds.
On the current Nushell website, for example [Quick Tour][quicktour] page,
we can see that the font-family being applied is in the generated style-*.css,
with declaration `code { font-family(--code-font-family); }`,
which does not match our supposed override which defines a var
under a different name `--font-family-code`.
This var name has been used since the introduction of the override in 83ced1d.
Maybe vuepress changed the variable at some point?
This is a follow-up to 2ec6143 (PR nushell#1890, PR nushell#1906),
which attempts to solve Android monospace due to missing font coverage (nushell#83).
Instead of replacing `--font-family-code`, `--code-font-family` is added as an additional value-identical declaration just in case the other variable is being used somewhere still.
[quicktour]: https://www.nushell.sh/book/quick_tour.html#nushell-commands-output-data
|
Let's try and see. Thanks |
|
Unfortunately, vuepress puts their declaration after ours. I'll submit a followup. |
Kissaki
added a commit
to Kissaki/nushell.github.io
that referenced
this pull request
May 1, 2025
VuePress puts our `:root` declaration before their own, meaning the declaration we intended as an override was overridden instead. Use higher specificity (`body`) to make sure it takes precedence. This is a follow-up to nushell#1907
fdncred
pushed a commit
that referenced
this pull request
May 1, 2025
VuePress puts our `:root` declaration before their own, meaning the declaration we intended as an override was overridden instead. Use higher specificity (`body`) to make sure it takes precedence. This is a follow-up to #1907
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code blocks use a different variable, which this commit adds.
On the current Nushell website, for example Quick Tour page, we can see that the font-family being applied is in the generated style-*.css, with declaration
code { font-family(--code-font-family); }, which does not match our supposed override which defines a var under a different name--font-family-code.This var name has been used since the introduction of the override in 83ced1d.
Maybe vuepress changed the variable at some point?
This is a follow-up to 2ec6143 (PR #1890, PR #1906), which attempts to solve Android monospace due to missing font coverage (#83).
Instead of replacing
--font-family-code,--code-font-familyis added as an additional value-identical declaration just in case the other variable is being used somewhere still.