Add two style tweaks to improve tables in code blocks #738
Conversation
|
Let's try it out. |
|
A little better but not quite fixed using macos and msedge. |
I can't test on those browsers, but if it helps, when preparing this PR I used Firefox's developer tools, which has a really nice Font panel that is able to show the individual characters using each font. I basically experimented with tweaking the CSS in my browser until it looked OK in my machine, and submitted that patch because it was a strict improvement over the previous state. |
|
Looks good on Windows with msedge. I'm wondering if none of those fonts were found on macos? |
|
I looked and it seems that the problem is that it's choosing Monaco on MacOS, which is a monospace font but not a great one for drawing pictures. If I change it to "FiraCode Nerd Font Mono" or "Iosevka Nerd Font Mono" or "CaskaydiaCove Nerd Font Mono" it looks great. I guess it's just about what fonts you have on your system and which one it finds first. Maybe I can find a Consolas for mac. |
|
Consolas was a bust. Looked terrible on MacOS. |
|
@waldyrious I'm terribly sorry for keep you waiting so long, I have just noticed this PR after it has been merged. Maybe too many notifications make me missed this one. |
|
No worries @hustcer, that's perfectly understandable! Just let me know what you think of the changes :) |
|
@waldyrious It looks good to me, thanks |
Co-authored-by: nash <nash@iffy.me>
Demo using the latest blog post (at the time of writing) as an example.
Before:
After:
CC @hustcer who did a lot of work in the Vuepress setup in #465.
Also CC @Aloso who did similar tweaks back in #8 + #9.