document engine-p porting #3868
Conversation
See #3390 for all the details.
|
@stormasm 👋 you may find this interesting. The how to guide steps have been floating around my head for a few months so I figured to write them out since we have enough left to warrant interim documentation. |
|
It looks like a 1 step process. You start on point 1, then go to the next point 1, then to the next point 1. LOL |
ha! definitely my local markdown editing confusing it! i'll revise. |
|
@efx thanks for writing that up ---- looks good to me... |
| In many cases this is changing the function name and signature. | ||
| The function name goes from `run_with_actions` to `run`. | ||
| The signature goes from `Result<ActionStream, ShellError>` | ||
| to `Result<OutputStream, ShellError>`. |
There was a problem hiding this comment.
You might want to call out when you wouldn't be able to updated to OutputStream, eg when there are Actions that might also be part of the output.
There was a problem hiding this comment.
@jntrnr good point. Could you share an example PR or link to a source file of what you were thinking of? I'm having trouble finding or coming up with an example of this.
There was a problem hiding this comment.
@efx - One example is a command like open couldn't be converted because it can output an Action that will convert the data from one form to another.
|
Looks good! |
ghost
deleted the
See #3390 for all the details.