Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings functions #297

Merged
merged 7 commits into from
Feb 4, 2022
Merged

Keybindings functions #297

merged 7 commits into from
Feb 4, 2022

Conversation

elferherrera
Copy link
Contributor

Simplifying the keybinding functions and correcting default keybindings

@elferherrera elferherrera merged commit 18f5383 into nushell:main Feb 4, 2022
@fdncred
Copy link
Collaborator

fdncred commented Feb 4, 2022

is this working right? I only have 1 keybinding for vi_normal.

@sholderbach
Copy link
Member

The vi normal mode parser is handwritten and not available as a mapping. Q how we want to document it. Exposing it to configuration is definitely non trivial

@fdncred
Copy link
Collaborator

fdncred commented Feb 4, 2022

@sholderbach is there no way vi_normal can be more keybind-y? I'm looking at edit_mode/vi/commands.rs parse_command() and a lot of that looks like keybindings. But maybe these shouldn't be changeable. I mean, having a thing in vi mode means it will work like vi where $ moves to the end, etc. so, maybe we should just leave some things hard-coded here.

sigoden added a commit to sigoden/reedline that referenced this pull request Apr 22, 2024
fdncred pushed a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants