modify ci.yml to see if it will turn off code coverage in the reedline repo

[stormasm]

I find reviewing PRs with the code coverage turned on incredibly annoying and hard to understand
all of the other code that I need to understand what has changed...

Unless someone really feels strongly about having it in there I am going to remove it....

Thanks !

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ca229d) 47.59% compared to head (87cbf22) 47.59%.

❗ Current head 87cbf22 differs from pull request most recent head 39c3a68. Consider uploading reports for the commit 39c3a68 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #710   +/-   ##
=======================================
  Coverage   47.59%   47.59%           
=======================================
  Files          47       47           
  Lines        9312     9312           
=======================================
  Hits         4432     4432           
  Misses       4880     4880           

[fdncred]

I'm wondering if we can disable it without deleting the file just in case we want to easily enable it again?

There a action to upload the coverage results in the ci.yml file too.

[stormasm]

Here is a copy of the codecov.yml file

coverage:
  status:
    project:
      default:
        informational: true
    patch:
      default:
        informational: true

comment:
  layout: reach, diff, files
  behavior: default
  require_base: yes
  require_head: yes
  after_n_builds: 5 # Our test matrix currently has 5 configurations

[stormasm]

Here is a copy of the associated ci.yml file

on:
  pull_request:
  push: # Run CI on the main branch after every merge. This is important to fill the GitHub Actions cache in a way that pull requests can see it
    branches:
      - main

name: continuous-integration

jobs:
  build-lint-test:
    strategy:
      fail-fast: false
      matrix:
        platform: [ubuntu-latest]
        rust:
          - stable
        # Define the feature sets that will be built here (for caching you define a separate name)
        style: [bashisms, default, sqlite, basqlite, external_printer]
        include:
          - style: bashisms
            flags: "--features bashisms"
          - style: external_printer
            flags: "--features external_printer"
          - style: default
            flags: ""
          - style: sqlite
            flags: "--features sqlite"
          - style: basqlite
            flags: "--features bashisms,sqlite"

    runs-on: ${{ matrix.platform }}

    steps:
      - uses: actions/checkout@v3

      - name: Setup Rust toolchain
        uses: actions-rust-lang/setup-rust-toolchain@v1.3.4
      - name: Setup nextest
        uses: taiki-e/install-action@nextest
      - name: Setup cargo-llvm-cov
        uses: taiki-e/install-action@cargo-llvm-cov

      - name: Rustfmt
        run: cargo fmt --all -- --check

      - name: Clippy
        run: cargo clippy ${{ matrix.flags }} --all-targets --all -- -D warnings


      - name: Tests
        run: cargo llvm-cov nextest --all ${{ matrix.flags }} --lcov --output-path lcov.info

      - name: Doctests
        run: cargo test --doc ${{ matrix.flags }}

      - name: Upload coverage
        uses: codecov/codecov-action@v3
        with:
          files: lcov.info

[stormasm]

Note here is another copy of both files for archival reasons in case we want to change back the settings...

https://github.com/stormasm/nunotes/tree/main/archive

[stormasm]

For starters I will just attempt to modify the ci.yml action without actually deleting the codecov.yml file to see if that works and turns off code coverage...

If this doesn't work then we will remove the codecov.yml file...

I wish there was a setting that individuals could set to toggle code coverage on and off when you are looking at PRs.

Then you can review the code with out seeing all of the extraneous code coverage messages which get in the way of trying to understand the code changes...