Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quick completion #732

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix quick completion #732

merged 1 commit into from
Jan 29, 2024

Conversation

nibon7
Copy link
Contributor

@nibon7 nibon7 commented Jan 29, 2024

@fdncred
Copy link
Collaborator

fdncred commented Jan 29, 2024

Is there an example I can test this with? I'd like to see it working before I land it since there are no tests.

@nibon7
Copy link
Contributor Author

nibon7 commented Jan 29, 2024

It can be reproduced in nushell.

  1. touch aaa aba aab
  2. ls atabbtab

step 2 doesn't auto select aba before this pr.

@fdncred
Copy link
Collaborator

fdncred commented Jan 29, 2024

Makes sense. Thanks for the repro!

@fdncred fdncred merged commit a5d3c35 into nushell:main Jan 29, 2024
6 checks passed
@nibon7 nibon7 deleted the fix/quick_completion branch January 29, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-selecting completion when only one remains, sometimes doesn't work
2 participants