Skip to content

Fix datetime parsing #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2023
Merged

Fix datetime parsing #140

merged 2 commits into from
Jun 22, 2023

Conversation

glcraft
Copy link
Contributor

@glcraft glcraft commented Jun 22, 2023 •
edited
Loading

From #139

  • floating point seconds can have one or more digits (instead of up to 3)
  • datetime rule is prioritized over numbers rule, so that the year is not parsed as number first instead of a full date.
image

@fdncred fdncred merged commit 91e3c81 into nushell:main Jun 22, 2023
@fdncred
Copy link
Contributor

fdncred commented Jun 22, 2023

Thanks again!

@fdncred fdncred mentioned this pull request Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@glcraft @fdncred