Skip to content

screen.waitFor() does not return when setting non-default timeout #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
dancesWithBugs opened this issue Dec 3, 2020 · 2 comments
Closed
1 task done

Comments

@dancesWithBugs
Copy link
Contributor

Version

1.5.0

Description

The following minimal example will throw an exception, but the progam will not return. If you set the default value of 5000, it works as expected.

const nut = require('@nut-tree/nut-js')
async function run() {
	await nut.screen.waitFor('test.png', 10000) // 5000 would work
}
run()

Issue occurs on

  • Dev/Host system (GNU/Linux)
@s1hofmann
Copy link
Member

Hi @dancesWithBugs 👋

Can you confirm this behavior with @nut-tree/nut-js@next as well?
We recently updated the waitFor implementation due to a similar bug

@dancesWithBugs
Copy link
Contributor Author

I can confirm that the changes made to @next fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants