Reject promise if searchRegion outside screenSize #196
Conversation
Prevents a comparatively cryptic OpenCV runtime error.
There was a problem hiding this comment.
Hi @dancesWithBugs 👋
Thanks for your PR!
Would you mind adding a test verifying the updated implementation, if possible?
Please note that it won't be merged until the CI setup has been fully moved from Travis-CI to GitHub Actions, as we ran out of build credits on Travis and therefore are unable to run builds at the moment.
|
As for providing a test for my changes, I'm sorry to disappoint, but I will most likely not be writing one. I have yet to figure out how to properly set up a dev environment for nut.js/libnut etc, so could actually run any test cases I'd be writing. I believe I've asked you about that a while ago, but have not (yet) received an answer. Perhaps you could add a "Contribution" section to the respective READMEs of nut.js and related projects, giving a few pointers. Anyway, I am currently tending to other matters and I don't know if and when I might get back to nut.js again. |
|
Of course I'll be available for discussion of my PRs/issues and fixing any bugs in my PRs (as I just did). :) |
Prevents a comparatively cryptic OpenCV runtime error. Fixes #195.