-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement kill system call #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could you restore the submission checklist in the PR description?
@bayedieng I can't see any fixes for my comments. Perhaps did you forget to push commits? |
@nuta updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! I have few minor review comments:
Thanks @bayedieng! |
This pr implements the kill syscall in order to further linux compatibility, omitting permission checks as Linux capabilities need to be implemented to do so.
Pre-Submission Checklist
When you submit a PR, please make sure your PR satisfies the following checklist:
cargo clippy
warnings.rustfmt
.