Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement kill system call #153

Merged
merged 1 commit into from
Feb 26, 2022
Merged

Implement kill system call #153

merged 1 commit into from
Feb 26, 2022

Conversation

bayedieng
Copy link
Contributor

@bayedieng bayedieng commented Feb 12, 2022

This pr implements the kill syscall in order to further linux compatibility, omitting permission checks as Linux capabilities need to be implemented to do so.

Pre-Submission Checklist

When you submit a PR, please make sure your PR satisfies the following checklist:

  • I assert this contribution was authored by me.
  • I license this contribution under the license of this project.
  • The PR title describes your changes briefly and uses the present tense, without a trailing full stop.
  • The PR description describes the reason why we need the change.
  • This is an isolated change. No multiple changes and no unrelated changes are included.
  • Fixed all cargo clippy warnings.
  • Applied rustfmt.

Copy link
Owner

@nuta nuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you restore the submission checklist in the PR description?

kernel/syscalls/kill.rs Outdated Show resolved Hide resolved
kernel/syscalls/kill.rs Outdated Show resolved Hide resolved
Documentation/compatibility.md Outdated Show resolved Hide resolved
@bayedieng bayedieng requested a review from nuta February 25, 2022 22:50
@nuta
Copy link
Owner

nuta commented Feb 26, 2022

@bayedieng I can't see any fixes for my comments. Perhaps did you forget to push commits?

@bayedieng
Copy link
Contributor Author

@nuta updated.

Copy link
Owner

@nuta nuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I have few minor review comments:

kernel/syscalls/kill.rs Outdated Show resolved Hide resolved
kernel/syscalls/kill.rs Outdated Show resolved Hide resolved
@bayedieng bayedieng requested a review from nuta February 26, 2022 09:06
kernel/syscalls/kill.rs Outdated Show resolved Hide resolved
@bayedieng bayedieng requested a review from nuta February 26, 2022 10:50
@nuta nuta merged commit 5f10bc2 into nuta:main Feb 26, 2022
@nuta
Copy link
Owner

nuta commented Feb 26, 2022

Thanks @bayedieng!

@bayedieng bayedieng deleted the kill-syscall branch February 26, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants