build(lint): Add gocognit to golangci-lint linter list (#483)

gocognit aims to reduce "cognitive complexity" of functions.
nutanix-cloud-native · Sep 25, 2024 · 78f61d1 · 78f61d1
1 parent d967a56
commit 78f61d1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -9,6 +9,7 @@ linters:
     - nolintlint
     - staticcheck
     - unused
+    - gocognit
 linters-settings:
   nolintlint:
     require-explanation: true

diff --git a/controllers/helpers.go b/controllers/helpers.go
@@ -469,9 +469,10 @@ func deleteCategoryKeyValues(ctx context.Context, client *prismclientv3.Client,
 		ciValue := ci.Value
 		if gck, ok := groupCategoriesByKey[ciKey]; ok {
 			groupCategoriesByKey[ciKey] = append(gck, ciValue)
-		} else {
-			groupCategoriesByKey[ciKey] = []string{ciValue}
+			continue
 		}
+
+		groupCategoriesByKey[ciKey] = []string{ciValue}
 	}
 
 	for key, values := range groupCategoriesByKey {