Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(lint): Update golangci-lint-action version to v6 #474

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

thunderboltsid
Copy link
Contributor

@thunderboltsid thunderboltsid commented Aug 14, 2024

The current lint action has started failing so we are updating the lint action
to v6 and the underlying golangci-lint version to v1.59

@thunderboltsid thunderboltsid added the ignore-for-release Internal change to not include in Release Notes label Aug 14, 2024
@thunderboltsid thunderboltsid changed the title build(lint): Update golangci-lint version to v6 build(lint): Update golangci-lint-action version to v6 Aug 14, 2024
@deepakm-ntnx
Copy link
Contributor

build is failing with following everywhere https://productionresultssa12.blob.core.windows.net/actions-results/62f2b8f2-7e34-4b91-92d0-20d79bb5a80f/workflow-job-run-6f9f266d-98b1-58c4-8864-1815c0eaed6a/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-08-14T20%3A12%3A13Z&sig=gBFlHkslEdvYtazTiEw29x1Xy%2BChiRajnEACuP3Zxws%3D&ske=2024-08-15T06%3A23%3A08Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2024-08-14T18%3A23%3A08Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2024-05-04&sp=r&spr=https&sr=b&st=2024-08-14T20%3A02%3A08Z&sv=2024-05-04

2024-08-14T18:07:14.7300234Z Running [/home/runner/golangci-lint-1.60.1-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
2024-08-14T18:08:05.8663796Z ##[error]printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
2024-08-14T18:08:05.8668006Z ##[error]printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
2024-08-14T18:08:05.8672442Z ##[error]printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse (govet)
2024-08-14T18:08:05.8674152Z 
2024-08-14T18:08:05.8675096Z level=warning msg="[config_reader] The output format `github-actions` is deprecated, please use `colored-line-number`"
2024-08-14T18:08:05.8676097Z 
2024-08-14T18:08:05.8677001Z ##[error]issues found

@thunderboltsid thunderboltsid force-pushed the issue/bump-golangci-lint-version branch from e1b3f76 to c537d8f Compare August 15, 2024 14:42
@thunderboltsid thunderboltsid merged commit 973b197 into main Aug 15, 2024
5 of 9 checks passed
@thunderboltsid thunderboltsid deleted the issue/bump-golangci-lint-version branch August 15, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Internal change to not include in Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants