-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(template): add CONTROL_PLANE_ENDPOINT_IP to ignoredNodeIPs list in CCM #480
Conversation
6ccc358
to
28bd65c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
We also need to update the template in test/e2e/data/infrastructure-nutanix/ccm-update.yaml |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
=======================================
Coverage 33.00% 33.00%
=======================================
Files 17 17
Lines 1809 1809
=======================================
Hits 597 597
Misses 1192 1192
Partials 20 20 ☔ View full report in Codecov by Sentry. |
9e95a4b
to
8074789
Compare
What this PR does / why we need it:
By adding CONTROL_PLANE_ENDPOINT_IP to the ignoredNodeIPs in the CCM config, we ensure
CCM will not assign the CONTROL_PLANE_ENDPOINT_IP as the node IP for any node. This could
previously happen as both CONTROL_PLANE_ENDPOINT_IP and node IP on an external DHCP network
would be learned IPs. In case of a slow DHCP assignment, the CONTROL_PLANE_ENDPOINT_IP
could be assigned as the first learned IP on the VM leading to potential issues when the CCM would then
assign the first IP as the node IP even though it was a floating IP.
It also causing issue with IPAM mode and third-party tools who are using IP from nodes
How Has This Been Tested?:
manual deployment of modified ressources
Release note: