Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): add CONTROL_PLANE_ENDPOINT_IP to ignoredNodeIPs list in CCM #480

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

tuxtof
Copy link
Contributor

@tuxtof tuxtof commented Aug 26, 2024

What this PR does / why we need it:

By adding CONTROL_PLANE_ENDPOINT_IP to the ignoredNodeIPs in the CCM config, we ensure
CCM will not assign the CONTROL_PLANE_ENDPOINT_IP as the node IP for any node. This could
previously happen as both CONTROL_PLANE_ENDPOINT_IP and node IP on an external DHCP network
would be learned IPs. In case of a slow DHCP assignment, the CONTROL_PLANE_ENDPOINT_IP
could be assigned as the first learned IP on the VM leading to potential issues when the CCM would then
assign the first IP as the node IP even though it was a floating IP.
It also causing issue with IPAM mode and third-party tools who are using IP from nodes

How Has This Been Tested?:

manual deployment of modified ressources

Release note:

- Set CCM to ignore Control Plane IP

@thunderboltsid
Copy link
Contributor

@tuxtof we're bumping up CCM in #479 already. Can you approve that one, rebase this and keep the scope limited to adding control plane endpoint IP to the ignore IPs list?

@tuxtof tuxtof changed the title upgrade ccm to 0.4.1 + add ignore CP add ignore CONTROL_PLANE_ENDPOINT_IP in CCM Aug 26, 2024
@thunderboltsid thunderboltsid changed the title add ignore CONTROL_PLANE_ENDPOINT_IP in CCM feat(template): add CONTROL_PLANE_ENDPOINT_IP to ignored address list in CCM Aug 26, 2024
@tuxtof tuxtof force-pushed the upgrade/ccm-ignore-node branch from 6ccc358 to 28bd65c Compare August 26, 2024 14:28
@thunderboltsid thunderboltsid changed the title feat(template): add CONTROL_PLANE_ENDPOINT_IP to ignored address list in CCM feat(template): add CONTROL_PLANE_ENDPOINT_IP to ignoredNodeIPs list in CCM Aug 26, 2024
@thunderboltsid thunderboltsid added the enhancement New feature or request label Aug 26, 2024
@thunderboltsid thunderboltsid changed the title feat(template): add CONTROL_PLANE_ENDPOINT_IP to ignoredNodeIPs list in CCM fix(ccm): add CONTROL_PLANE_ENDPOINT_IP to ignoredNodeIPs list in CCM Aug 26, 2024
@thunderboltsid thunderboltsid added bug Something isn't working and removed enhancement New feature or request labels Aug 26, 2024
@thunderboltsid thunderboltsid changed the title fix(ccm): add CONTROL_PLANE_ENDPOINT_IP to ignoredNodeIPs list in CCM fix(template): add CONTROL_PLANE_ENDPOINT_IP to ignoredNodeIPs list in CCM Aug 26, 2024
Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thunderboltsid
Copy link
Contributor

We also need to update the template in test/e2e/data/infrastructure-nutanix/ccm-update.yaml

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.00%. Comparing base (0e42e21) to head (8074789).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   33.00%   33.00%           
=======================================
  Files          17       17           
  Lines        1809     1809           
=======================================
  Hits          597      597           
  Misses       1192     1192           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuxtof tuxtof force-pushed the upgrade/ccm-ignore-node branch from 9e95a4b to 8074789 Compare August 26, 2024 18:21
@tuxtof tuxtof requested a review from adiantum August 26, 2024 19:53
@thunderboltsid thunderboltsid merged commit 296b7b6 into main Aug 26, 2024
9 of 11 checks passed
@thunderboltsid thunderboltsid deleted the upgrade/ccm-ignore-node branch August 26, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants