add support for migration v2 to the spec #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pulls in the version of the spec that was submitted to qemu-devel: https://lists.nongnu.org/archive/html/qemu-devel/2023-06/msg06567.html This version of the spec removes live migration support as it will be added later on following v2 of the VFIO migration protocol. However, we will not remove the code for live migration v1 until we implement v2. We do not implement all of the other new changes in this spec update but are otherwise compatible. Signed-off-by: William Henderson <william.henderson@nutanix.com>
This adds the VFIO_USER_DEVICE_FEATURE, VFIO_USER_MIG_DATA_READ, and VFIO_USER_MIG_DATA_WRITE commands. Signed-off-by: William Henderson <william.henderson@nutanix.com>
tmakatos
reviewed
Jul 12, 2023
tmakatos
reviewed
Jul 12, 2023
Signed-off-by: William Henderson <william.henderson@nutanix.com>
Signed-off-by: William Henderson <william.henderson@nutanix.com>
jlevon
reviewed
Jul 17, 2023
Signed-off-by: William Henderson <william.henderson@nutanix.com>
jlevon
approved these changes
Jul 17, 2023
|
@w-henderson I think this can now be merged into master-migv2? |
|
@tmakatos Yes, I think it's all good - go ahead! |
|
@w-henderson looks like there are conflicts? |
w-henderson
force-pushed
the
w-henderson/migration-v2-spec
branch
from
6d8f2f4
to
d3727cc
Compare
|
@tmakatos I have no idea what was going on with the conflicts - Git seemed to be finding conflicts between identical paragraphs of text and the above merge commit is literally an empty commit, but apparently that fixed the conflicts? Anyway it's good to merge now (I hope). |
tmakatos
approved these changes
Jul 26, 2023
|
Ugh, I botched the commit message. Anyway, let's fix it when merging to master. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the VFIO_USER_DEVICE_FEATURE, VFIO_USER_MIG_DATA_READ, and VFIO_USER_MIG_DATA_WRITE commands.