Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: server sample not marking dirty pages #748

Merged
merged 12 commits into from
Aug 2, 2023
Merged

fix: server sample not marking dirty pages #748

merged 12 commits into from
Aug 2, 2023

Commits on Aug 2, 2023

  1. fix: server sample not marking dirty pages 

    In `do_dma_io`, the server sample was calling `vfu_sgl_write` without calling
`vfu_sgl_mark_dirty`, which resulted in no pages being marked dirty.

Signed-off-by: William Henderson <william.henderson@nutanix.com>
    @w-henderson
    w-henderson committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    467b372 View commit details
    Browse the repository at this point in the history

  2. add check in client that pages are dirtied 

    Signed-off-by: William Henderson <william.henderson@nutanix.com>
    @w-henderson
    w-henderson committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    e530852 View commit details
    Browse the repository at this point in the history

  3. add assertion that we only dirty first 8 pages 

    Signed-off-by: William Henderson <william.henderson@nutanix.com>
    @w-henderson
    w-henderson committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    765c2e1 View commit details
    Browse the repository at this point in the history

  4. assert that client/server example dirties some pages 

    Signed-off-by: William Henderson <william.henderson@nutanix.com>
    @w-henderson
    w-henderson committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1379638 View commit details
    Browse the repository at this point in the history

  5. have server sample use vfu_sgl_write and direct writes 

    Signed-off-by: William Henderson <william.henderson@nutanix.com>
    @w-henderson
    w-henderson committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5d866f6 View commit details
    Browse the repository at this point in the history

  6. have client track pages dirtied by messages 

    Signed-off-by: William Henderson <william.henderson@nutanix.com>
    @w-henderson
    w-henderson committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    eef1828 View commit details
    Browse the repository at this point in the history

  7. fix: use vfu_sgl_put correctly 

    Signed-off-by: William Henderson <william.henderson@nutanix.com>
    @w-henderson
    w-henderson committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    52f2ae9 View commit details
    Browse the repository at this point in the history

  8. use vfu_sgl_mark_dirty with explanatory comment 

    Signed-off-by: William Henderson <william.henderson@nutanix.com>
    @w-henderson
    w-henderson committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    357cdc8 View commit details
    Browse the repository at this point in the history

  9. make client dirty page tracking less hacky 

    Signed-off-by: William Henderson <william.henderson@nutanix.com>
    @w-henderson
    w-henderson committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    87fe917 View commit details
    Browse the repository at this point in the history

  10. minor comment wording changes 

    Signed-off-by: William Henderson <william.henderson@nutanix.com>
    @w-henderson
    w-henderson committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    d12239e View commit details
    Browse the repository at this point in the history

  11. fix: small style things 

    Signed-off-by: William Henderson <william.henderson@nutanix.com>
    @w-henderson
    w-henderson committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    a4b9b0e View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' into sample-dirty-pages

    @w-henderson
    w-henderson authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    4623299 View commit details
    Browse the repository at this point in the history