More Distros for Pull-Request Workflow #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node12 and as a result Github Actions v2 will apparently soon be deprecated, see: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/ Thus this changes all workflow jobs to use `actions/checkout@v3`. Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
This adds jobs to `.github/workflows/pull_request.yml` for Debian 11 bullseye, Debian 12 bookworm and Arch Linux base 20230723.0.166908. Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
The newer flake8 version in the arch linux job of the pull request workflow fails due to: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` Both `__eq__` functions now use `is not` instead of `!=` for the type initial check. Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
|
thanks! Could you also add these to required status checks in settings.yml? |
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
jlevon
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does three things:
As suggested in Add another lspci test output variant #761 this adds a job for Arch Linux (base 20230723.0.166908), but since I was already at it also Debian 11 bullseye and Debian 12 bookworm, to the pull request workflow.
During testing I stumbled across a linting error thrown by the newer flake8 version in the Arch job, see
I altered the mentioned equality checks in
test/py/libvfio_user.pyto fix this.It also bumps the version of Github Actions to v3 in all workflows. v2 will apparently be deprecated over the summer, see https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/ and
I already tested this on my own runner, see https://github.com/gierens/libvfio-user/actions/runs/5868047364 or
seems to work. I'm also a bit surprised how fast the arch job is.