Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update samples to use migration v2 #776

Merged
merged 16 commits into from
Sep 15, 2023
Merged

update samples to use migration v2 #776

merged 16 commits into from
Sep 15, 2023

Conversation

w-henderson
Copy link
Contributor

@w-henderson w-henderson commented Aug 30, 2023 •
edited
Loading

This commit updates the code samples to demonstrate usage of the migration v2 API.

tmakatos
tmakatos reviewed Aug 30, 2023
View reviewed changes
samples/client.c Show resolved Hide resolved
samples/client.c Outdated Show resolved Hide resolved
samples/client.c Outdated Show resolved Hide resolved
samples/client.c Outdated Show resolved Hide resolved
samples/client.c Outdated Show resolved Hide resolved
samples/client.c Outdated Show resolved Hide resolved
samples/server.c Outdated Show resolved Hide resolved
samples/server.c Outdated Show resolved Hide resolved
samples/server.c Outdated Show resolved Hide resolved
samples/server.c Outdated Show resolved Hide resolved
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-samples branch 3 times, most recently from d49308d to fa1f998 Compare August 31, 2023 09:19
tmakatos
tmakatos approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@tmakatos tmakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, re: total_read, you can just add a comment instead of renaming the variable.

@w-henderson
Copy link
Contributor Author

Too late, I renamed it! Thanks for the approval.

@w-henderson w-henderson force-pushed the w-henderson/migration-v2-samples branch 2 times, most recently from c49635f to f6562c1 Compare September 4, 2023 10:23
Base automatically changed from w-henderson/migration-v2-implementation to master-migv2 September 15, 2023 11:59
@w-henderson @jlevon
update samples to use migration v2
965c28e 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
fix: work with changes to implementation
bba72fc 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
fix: changes to samples according to comments
315cb9d 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
feat: implement DMA logging in client/server sample
f05fd00 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
fix: conflict with kernel definitions in samples
fb15a53 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
fix: obvious use-after-free
5781f1a 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
fix: update sample to correctly start destination server
62f7dd9 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
fix: minor fixes from Swapnil's review
5f75027 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
reintroduce mmap_sparse_areas in client.c
795252c 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
fix: fixes for changes from John's core review
f77f457 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
fix: minor changes to samples according to John's review
557af66 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
fix: argsz semantics in samples
1907a10 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
respond to Swapnil's review
da9be96 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
respond to Thanos's review
bd0e0cf 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
rename get_bitmap_size
2348710 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@w-henderson @jlevon
rename some variables
2101ec4 
Signed-off-by: William Henderson <william.henderson@nutanix.com>
@jlevon jlevon force-pushed the w-henderson/migration-v2-samples branch from f6562c1 to 2101ec4 Compare September 15, 2023 12:04
@jlevon jlevon merged commit 2287a79 into master-migv2 Sep 15, 2023
1 of 5 checks passed
@jlevon jlevon deleted the w-henderson/migration-v2-samples branch September 15, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmakatos tmakatos tmakatos approved these changes

Assignees
No one assigned
Labels
migration-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@w-henderson @tmakatos @jlevon