Conversation
Co-authored-by: carlosbornes <carlos.bornes@natur.cuni.cz> Co-authored-by: danielcunhapereira <cunha.daniel@ua.pt>
It was impossible to get convert directly from a `spe` in Hz to ppm, without first going to `fid`. Also added some shortcuts, especially for @danielcunhapereira
| if file_data.format == 'fid': | ||
| new_data = file_data.to_spe() | ||
| else: | ||
| new_data = file_data |
Collaborator
There was a problem hiding this comment.
Without this one can not go directly from hz to ppm. Now it should work fine. Tested it on the data from the repo
Collaborator
|
It should work now. Only found one minor mistake and fixed. Also added |
carlosbornes
added a commit
that referenced
this pull request
Apr 26, 2025
Revamp of GUI Menu and some extras Co-authored-by: Daniel Pereira <cunha.daniel@ua.pt> Co-authored-by: Carlos Bornes <carlos.bornes@natur.cuni.cz> Co-authored-by: Marcio Soares <marciosoares@ua.pt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@carlosbornes could you please review the code when you have the time?