Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rewards in redeem #23

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Update rewards in redeem #23

merged 2 commits into from
Oct 30, 2023

Conversation

zjb0807
Copy link
Contributor

@zjb0807 zjb0807 commented Oct 23, 2023 •
edited
Loading

In redeem, totalSupply was updated, and the fee was not recorded in rewards.

@zjb0807 zjb0807 requested a review from ukby1234 October 23, 2023 04:14
@ukby1234
Copy link
Contributor

This isn't the actual fee. In almost all cases, the returned value will be close to 0. It's for making the pool calculation accurate due to rounding errors from exchange rates.

@zjb0807 zjb0807 changed the title Fix actualFee in Events Update rewards in redeem Oct 26, 2023
@zjb0807 zjb0807 merged commit 3511900 into v1.5_deployment Oct 30, 2023
1 check failed
@zjb0807 zjb0807 deleted the fix-actual-fee branch October 30, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukby1234 ukby1234 ukby1234 approved these changes

@Mars12-dev Mars12-dev Awaiting requested review from Mars12-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zjb0807 @ukby1234