Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and archive build artifacts #51

Merged
merged 1 commit into from
Jun 28, 2020

Conversation

grische
Copy link
Contributor

@grische grische commented Jun 21, 2020

Purpose of the pull request
Create and store all build artifacts for automatic building and hence easy testing.

See artifacts for current PR: https://github.com/nutti/fake-bpy-module/actions/runs/148697983

Description about the pull request
In this PR, we are creating artifacts for the "raw_modules" folder and the generated pip packages.
The pip artifact allows you to manually download and install on your local machine with the pip install <filename> command.

I chose a second-exact resolution timestamp for the files, as we might have multiple builds per day. While all those artifact filenames have a timestamp as a version, I did not (as requested) modify the RELEASE_VERSION.

Additional comments [Optional]
EDIT: I removed all independent parts of this PR and focus primarily on generating artifacts.

Should some parts of the CI fail (for example, 2.82 fails while 2.79 builds), then the artifacts for 2.79 are still being saved. For example: https://github.com/grische/fake-bpy-module/actions/runs/148676363

@grische grische force-pushed the feature/create_build_archives branch 4 times, most recently from 952dcef to 59ad726 Compare June 26, 2020 13:03
@grische
Copy link
Contributor Author

grische commented Jun 26, 2020

@nutti I updated this PR and modified the description accordingly

The artifacts can be found on the following page after all jobs have succeeded: https://github.com/nutti/fake-bpy-module/actions/runs/148697983

@grische grische marked this pull request as ready for review June 26, 2020 13:07
Copy link
Owner

@nutti nutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I have a question about this feature.

Is it possible to pack all pip or raw files to one file such as all.zip.
It is convenient for me to download all artifacts at once.

  • fake_bpy_modules_2.*_* -> fake_bpy_modules_pip_all.zip
  • fake_bpy_modules_2.*_* -> fake_bpy_modules_raw_all.zip

@grische
Copy link
Contributor Author

grische commented Jun 27, 2020

Thanks.
I have a question about this feature.

Is it possible to pack all pip or raw files to one file such as all.zip.
It is convenient for me to download all artifacts at once.

@nutti Can you explain your use-case to me?

With the fully parallel run (i.e. with Matrix Actions), every parallel run generates some artifacts. We can of course create another job in the CI which downloads each artifact, uncompresses it, re-compress it into a single file, and publishes a new artifact (and delete the other artifacts).
I thought that additional complexity in the CI is not needed. Maybe I missed a use-case there.

I thought of this use-case for myself:

  • Publishing to PyPi / TestPyPi
    Publishing we can do via Github Actions in the future, so this should not be a problem.

@grische
Copy link
Contributor Author

grische commented Jun 27, 2020

We can also of course do this later as an improvement. I have a few more suggestions to improve the artifacts (e.g. the content of the artifacts, the bash scripts re- and decompress zip files, etc).

@grische grische force-pushed the feature/create_build_archives branch from 59ad726 to 45284c0 Compare June 27, 2020 20:36
@grische
Copy link
Contributor Author

grische commented Jun 27, 2020

Rebased on top of master, running CI including the new tests: https://github.com/nutti/fake-bpy-module/actions/runs/149968450

Copy link
Owner

@nutti nutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. The improvement should be discussed in other issue.
I have a one comment about the name of artifacts.

.github/workflows/fake-bpy-module-ci.yml Show resolved Hide resolved
Copy link
Owner

@nutti nutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/fake-bpy-module-ci.yml Show resolved Hide resolved
@nutti nutti merged commit 21e60df into nutti:master Jun 28, 2020
@grische grische deleted the feature/create_build_archives branch June 28, 2020 10:39
nutti pushed a commit that referenced this pull request Jul 4, 2020
nutti pushed a commit that referenced this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants