Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.3.0 #678

Merged
merged 25 commits into from
Aug 30, 2024
Merged

Version 2.3.0 #678

merged 25 commits into from
Aug 30, 2024

Conversation

nuttyartist
Copy link
Owner

@nuttyartist nuttyartist commented Jun 22, 2024

This branch adds the following improvements:

There are some more changes I want to make before merging this. This is why it's labeled WIP.

@nuttyartist nuttyartist requested review from guihkx and zjeffer June 22, 2024 22:53
@vlasky
Copy link

vlasky commented Jun 27, 2024

Very happy to see this progress! I am eagerly awaiting encrypted sync functionality between multiple instances on different PCs. For me, that's the killer feature that would make this perfect!

@nuttyartist
Copy link
Owner Author

Thanks, @vlasky! I don't have a plan to support built-in sync for Notes at this time. If anyone would like to contribute such a thing, I will happily merge it. But I do have plans to support sync for my note-taking app Plume (https://www.get-plume.com/) that shares the same database with Notes.

@nuttyartist
Copy link
Owner Author

Hey everyone,

I want to announce some changes that will go live in a few days.

The reason for the rebranding is to streamline all my product offerings (current and future) under one brand name (Daino).

Let me know if you have any questions/suggestions.

@guihkx
Copy link
Collaborator

guihkx commented Aug 28, 2024

The current user base of Notes will get an update to Daino Notes.

Just to be sure, you mean paid users of current "Notes PRO", correct?

The new Notes FOSS app will use a different update file.

I'm not sure I understand the reason behind this change. Won't it completely break the update checking feature?

By the way, I personally think these changes warrant a $minor version bump, instead of just a $patch one.

Lastly, can we provide feedback on the changes already, or do you prefer us to wait until the WIP tag is removed?

@nuttyartist
Copy link
Owner Author

nuttyartist commented Aug 28, 2024

By the way, I personally think these changes warrant a $minor version bump, instead of just a $patch one.

Yes, you're right. I'll update this.

Just to be sure, you mean paid users of current "Notes PRO", correct?
I'm not sure I understand the reason behind this change. Won't it completely break the update checking feature?

No, all current users of Notes will get an update to Daino Notes (apart from those for whom it's disabled, like those from the Snap Store or FlatHub, if I remember correctly). It will provide links to notes-foss.com if users wish to continue using the FOSS version (i.e., this repo).

I'm releasing Daino Notes in the coming days so that will take effect very soon.

Lastly, can we provide feedback on the changes already, or do you prefer us to wait until the WIP tag is removed?

Yes, you can provide feedback, for sure.

Current TODO:

  • Linting
  • Bump to minor version
  • New update file

@nuttyartist nuttyartist changed the title Version 2.2.2 WIP Version 2.2.2 Aug 28, 2024
@guihkx
Copy link
Collaborator

guihkx commented Aug 28, 2024

No, all current users of Notes will get an update to Daino Notes (apart from those for whom it's disabled, like those from the Snap Store or FlatHub, if I remember correctly). It will provide links to notes-foss.com if users wish to continue using the FOSS version (i.e., this repo).

Got it, but isn't Daino Notes fully proprietary, though?

If that's the case, I don't think it'd be ethical from us to sneak in an update that will replace a FOSS app by a proprietary one...

@zjeffer
Copy link
Collaborator

zjeffer commented Aug 28, 2024

If that's the case, I don't think it'd be ethical from us to sneak in an update that will replace a FOSS app by a proprietary one...

I fully agree with this: I think many users use Notes because it's open-source. Auto-updating to a proprietary version would piss off a lot of people (and rightfully so, imo)

@nuttyartist
Copy link
Owner Author

Current users who will update from Notes to Daino Notes will be greeted with a screen that will explain about the change and will allow them to download the FOSS version at any time. Since Daino Notes and Notes FOSS (this repo) share exactly the same database, no change to their data will take effect.

Also, Daino Notes will comply with the MPL license of Notes so all the code that is used from Notes will be uploaded to https://github.com/nuttyartist/daino-notes-public.

Even though Notes is currently open source, it has always been and still is a project that I've been trying to make a living from. This proved difficult. So, making a clear distinction between the FOSS vision and the non-FOSS will probably be better in the long run.

81% of the visits to the website comes from Google after searching for the keyword "notes". So most users of Notes probably don't know what open source means and don't even understand that Notes is open source at all. They are lay people who are looking for a place to jot down their thoughts. So while it's true there are many who use Notes because it's open source, it's quite certain that most users don't.

I do understand that it's in a tricky ethical category for users who downloaded Notes because it's open source, but they always have the option to switch to the FOSS version, and they are most certainly a minority in the user base, as it stands.

@guihkx
Copy link
Collaborator

guihkx commented Aug 28, 2024

Even though Notes is currently open source, it has always been and still is a project that I've been trying to make a living from. This proved difficult. So, making a clear distinction between the FOSS vision and the non-FOSS will probably be better in the long run.

There's no problem in trying to make money off of open source, I just think the current approach is not the best.

I'd actually be more okay with a pop up nagging Notes FOSS users to try out Daino Notes, than actually forcing it on them without them knowing or consenting to it first.

Also, Daino Notes will comply with the MPL license of Notes so all the code that is used from Notes will be uploaded to https://github.com/nuttyartist/daino-notes-public.

That's great, but it's precisely the proprietary, kept-private code that will concern people. As opposed to Notes FOSS, people obviously can't know what Daino Notes does because not all the code is auditable.

So while it's true there are many who use Notes because it's open source, it's quite certain that most users don't.

I don't know, even if that's true - we can only know for sure if we actually ask them -, I still think doing this is really shady and a breach of trust, regardless of the target being your average Joe or a FOSS expert.

I can even imagine the more technical people eventually noticing this was done, and being very vocal about it in places like Reddit. That would inevitably inflict heavy damage on this project and likely your other projects and brands, too...

@nuttyartist
Copy link
Owner Author

That's great, but it's precisely the proprietary, kept-private code that will concern people. As opposed to Notes FOSS, people obviously can't know what Daino Notes does because not all the code is auditable.

Most (if not all) of the code that connects to the internet will be open source, if that's the part of the code that you think will concern people.

I don't know, even if that's true - we can only know for sure if we actually ask them -, I still think doing this is really shady and a breach of trust, regardless of the target being your average Joe or a FOSS expert.

Highly likely the average user didn't even know that the app was open source, so I don't agree with your statement in that scenario - they are most likely not operating on different information than before the update. I do admit that this decision is ethically not optimal for users who downloaded Notes because it's FOSS. But these users can easily download the FOSS version with completely no affect to their data.

@nuttyartist
Copy link
Owner Author

nuttyartist commented Aug 30, 2024

BTW, commit df7e4db is necessary to make the license for Notes FOSS work (since I'm using the old Notes Lemon Squeezy store for Daino Notes). So the endpoints at daino.io/notes_foss testing the licenses on my own DB (hosted on Supabase). To be fully FOSS, I'll of course open source these end points as well, soon enough.

EDIT: I'll probably put these endpoints at notes-foss.com and not daino.io, now that I think of it. I just need to change the website a bit to make this work. This will be better. So these server endpoints (except for the secrets, of course) will be open sourced here: https://github.com/nuttyartist/notes-foss-website

@nuttyartist nuttyartist changed the title Version 2.2.2 Version 2.3.0 Aug 30, 2024
@nuttyartist nuttyartist merged commit 78d35ff into master Aug 30, 2024
17 checks passed
@guihkx guihkx deleted the version-2.2.2 branch September 10, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two warnings in SubscriptionWindow.qml with Qt 6.7.1
5 participants