Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/macOS: Update to macOS 13 #700

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

guihkx
Copy link
Collaborator

@guihkx guihkx commented Sep 29, 2024

This is mainly done because Homebrew has recently dropped support for macOS 12, which causes a massive slowdown in CI when installing Qt 6, because it has to be built from source.

Closes #699

This is mainly done because Homebrew has recently dropped support for
macOS 12, which causes a massive slowdown in CI when installing Qt 6,
because it has to be built from source.
@guihkx
Copy link
Collaborator Author

guihkx commented Sep 29, 2024

Apparently, GitHub's macOS 13 runner can cause some spurious errors when running create-dmg:

image

It seems to be a very common error, too: actions/runner-images#7522

The Qt 6 build passed the first attempt, but the Qt 5 one needed 5(!) rebuilds to finally pass... 😢

image


Anyway, just to be sure, I've tested the resulting Qt 5 and Qt 6 build artifacts on macOS 11 Big Sur, and they still work:

Qt 5:

Screenshot

image

Qt 6:

Screenshot

image

@guihkx guihkx merged commit 292414a into nuttyartist:master Sep 29, 2024
17 checks passed
@guihkx guihkx deleted the ci-macos13 branch September 29, 2024 22:13
@nuttyartist
Copy link
Owner

Damn, @guihkx thanks so much for this work!

@nuttyartist
Copy link
Owner

Did we solve the hdiutil failures?

@guihkx
Copy link
Collaborator Author

guihkx commented Dec 9, 2024

In a way, yes.

Now we keep invoking it until it works:

# FIXME: Undo this overengineered crap once the following issue gets figured out:
# https://github.com/actions/runner-images/issues/7522
max_tries=10
i=0
until create-dmg \
--no-internet-enable \
--format ULFO \
--background ../packaging/macos/dmg-background.png \
--hide-extension 'Notes Better.app' \
--icon 'Notes Better.app' 180 170 \
--icon-size 160 \
--text-size 12 \
--volname Notes \
--volicon ../src/images/notes_icon.icns \
--window-size 660 400 \
--app-drop-link 480 170 \
'${{ steps.vars.outputs.file_name }}' \
'Notes Better.app'
do
if [ $i -eq $max_tries ]
then
echo 'Error: create-dmg did not succeed even after 10 tries.'
exit 1
fi
i=$((i+1))
done

@nuttyartist
Copy link
Owner

nuttyartist commented Dec 9, 2024

I forgot, did using root didn't work?

@guihkx
Copy link
Collaborator Author

guihkx commented Dec 9, 2024

Nope.

I tried that on #712, and it failed right after the PR got merged: https://github.com/nuttyartist/notes/actions/runs/11423877142/job/31783553788#step:13

@nuttyartist
Copy link
Owner

Alrighty, thanks for all the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the macOS version used in GitHub Actions (again)
3 participants