Support entity extra fields #108 #137
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuaelFr
suggested changes
May 23, 2018
| if (!$this->getContextProperty('limit')) { | ||
| $sources[] = $this->getSourceField($extra_field_name, $field['label']); | ||
| } | ||
| elseif (in_array($extra_field_name, $this->getContextProperty('limit'))) { |
There was a problem hiding this comment.
These conditions could be merged with a "||"
if (!$this->getContextProperty('limit') || in_array($extra_field_name, $this->getContextProperty('limit'))) {
|
Did I say it works well? :) |
jcnventura
reviewed
Oct 31, 2018
| $plugin_id, | ||
| $plugin_definition, | ||
| $container->get('plugin.manager.ui_patterns'), | ||
| $container->get('typed_data_manager'), |
There was a problem hiding this comment.
Why add UiPatternsManager and TypedDataManager to the constructor, if they aren't being stored or used anywhere?
DuaelFr
pushed a commit
to DuaelFr/ui_patterns
that referenced
this pull request
Nov 30, 2019
DuaelFr
pushed a commit
to DuaelFr/ui_patterns
that referenced
this pull request
Oct 29, 2020
|
This PR has been moved to Drupal.org issue queue: https://www.drupal.org/project/ui_patterns/issues/3311088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support entity extra fields #108