Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs with for non standard protocol are parsed incorrectly #1854

Closed
rgavilan opened this issue Jul 1, 2022 · 1 comment
Closed

URLs with for non standard protocol are parsed incorrectly #1854

rgavilan opened this issue Jul 1, 2022 · 1 comment
Labels
kind/bug v3 3.0 version

Comments

@rgavilan
Copy link

rgavilan commented Jul 1, 2022

sysPass Version
3.2.10

Describe the bug
Regarding to #1844 and #1840, the problems were solved, but I also detected a new one relative to URLs with a non standard protocol such as mongodb+srv, for instance an URL from MongoDB Atlas is mongodb+srv://cluster.foo.mongodb.net/bar. At account search is shown as mongodb%2Bsrv://cluster.foo.mongodb.net/bar.

The same problem is detected when we introduce instead of an standard URL a remote folder location such as \\foo\bar, in this case is shown as %5C%5Cfoo%5Cbar.

To Reproduce
Steps to reproduce the behavior:

  1. Set an URL in an account in non standard format, for instance mongodb+srv://cluster.foo.mongodb.net/bar or \\foo\bar
  2. Goto search screen and locate the account
  3. Look at the URL and the link
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

When the URL is not recognized as a standard http or https one, it should be shown as plain text (instead of a link) and without been parsed.

Screenshots

image

image

nuxsmin added a commit that referenced this issue Jul 2, 2022
Closes #1854. Thanks for the feedback @rgavilan !!

Signed-off-by: Rubén D <nuxsmin@syspass.org>
@nuxsmin
Copy link
Owner

nuxsmin commented Jul 2, 2022

Hello, sorry for the inconvenience, it seems that URL encoding within href tags is quite difficult to achieve and there isn't too much documentation or tooling to handle it correctly.

This should be solve in latest release.

Thanks for the feedback!!

@nuxsmin nuxsmin closed this as completed Jul 2, 2022
@nuxsmin nuxsmin added kind/bug v3 3.0 version labels Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug v3 3.0 version
Projects
None yet
Development

No branches or pull requests

2 participants