feat: typescript typings and example #486

NickBolles · 2019-11-20T16:56:21Z

No description provided.

codecov · 2019-11-20T16:58:05Z

Codecov Report

Merging #486 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev      #486   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9d0555...488595a. Read the comment docs.

NickBolles · 2019-11-20T17:29:35Z

Followup - Remove package from DefinitelyTyped - https://github.com/DefinitelyTyped/DefinitelyTyped#removing-a-package

NickBolles · 2019-12-07T04:42:40Z

reminder to look at changes to the @types package #40778 linked above and DefinitelyTyped/DefinitelyTyped#40840 before merging

davidlandais · 2019-12-20T12:41:16Z

Why are you waiting to merge this PR ? 👍

pi0

Thanks for PR

package.json

docs/guide/setup.md

examples/with-typescript/mixins/auth.ts

examples/with-typescript/nuxt.config.ts

examples/with-typescript/package.json

examples/with-typescript/tsconfig.json

package.json

types/index.d.ts

NickBolles · 2020-01-20T14:43:32Z

Thanks for the review @kevinmarrec and @pi0 I'll look at these today, rebase and resubmit.

NickBolles · 2020-02-04T03:11:31Z

As part of the conversion to use async as requested. I removed the comments suggesting async


    // If you are not fond of using axios promises on async calls
    // You can still use Javascript try and catch block
    //
    // try {
    //   this.$toast.show('Logging out...')
    //   await this.$auth.logout()
    //   this.$toast.success('Successfully disconnected')
    // } catch (err) {
    //   this.$toast.error('Error while connecting: ' + err.message)
    // }

NickBolles · 2020-02-04T04:05:56Z

@kevinmarrec @pi0

Thanks for the review @kevinmarrec and @pi0 I'll look at these today, rebase and resubmit.

So much for "today"... All of these should be fixed finally. The examples should be working correctly too. Let me know if you see anything else!

localhost5001 · 2020-02-27T18:56:08Z

Any updates?

pi0

Thanks for the PR ❤️ I put some comments.

lib/core/middleware.js

lib/core/hook.js

Source: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43380/files

NickBolles · 2020-03-25T14:11:17Z

@pi0 @kevinmarrec Could you guys take another look? somehow I merged two branches and added a bunch of incorrect changes in the middle of this PR. (probably cuz I'm on a dev branch and not a feature branch....) Should be good to go.

Should also make changes like this: DefinitelyTyped/DefinitelyTyped#43380 easier

kevinmarrec

Sounds good to me

JoaoPedroAS51

Hi! Nice work! 😃 I left some comments related to latest changes on dev branch.

types/index.d.ts

examples/with-typescript/pages/secure.vue

types/index.d.ts

NickBolles · 2020-04-09T01:41:15Z

Alright I think I've made those updates besides RefreshController and RequestHandler.

Side note: am I supposed to mark the comments as resolved? or leave that for reviewers to resolve?

Also, I'm really tempted to just rename everything to .ts and add a build step. It would make these types way more complete and way less maintenance, not to mention make the library more approachable for newcomers, since typescript is easier to see mistakes.

t-eckert · 2020-04-12T05:55:38Z

As a user, looking forward to seeing this merged!

JoaoPedroAS51

Hi! Nice work! Almost done! 😄 I think there is only one last thing to fix.

JoaoPedroAS51 · 2020-04-14T16:37:21Z

types/requestHandler.d.ts

@@ -0,0 +1,8 @@
+export default class RequestHandler {
+    constructor(auth: any);
+    $auth: any;


$auth shouldn't be the Auth class?

Also, import @nuxt/auth relatively in the typescript example's package.json

NickBolles · 2020-04-19T01:56:32Z

closing in favor of #622

pi0 · 2020-04-21T09:52:36Z

Hi @NickBolles Nice work. I may bring some parts from your works but it will only cover internal TS rewrite and auto-generated types.

Are you interested in helping with a new typescript section in docs and creating a repository for with-typescript example? We can then link it from docs :)

NickBolles · 2020-04-21T11:27:19Z

Sure! Where/when is the typescript re-writes happening? I was tempted to just rename everything to .ts and add a compile step instead of adding the types.

I'd be interested in helping out or reviewing the typescript migration.

JoaoPedroAS51 · 2020-04-21T11:31:41Z

@NickBolles Hi! Check #621

NickBolles · 2020-04-21T12:03:05Z

@NickBolles Hi! Check #621

Perfect. Thanks!

NickBolles mentioned this pull request Nov 20, 2019

Docs: Add best practices for modules to support Typescript nuxt/typescript#200

Open

NickBolles mentioned this pull request Nov 21, 2019

Typescript Types #274

Closed

NickBolles mentioned this pull request Dec 7, 2019

[nuxtjs__auth] added missing declarations DefinitelyTyped/DefinitelyTyped#40778

Merged

9 tasks

pi0 reviewed Jan 13, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

pi0 requested a review from kevinmarrec January 13, 2020 10:19

pi0 changed the title ~~Typescript - Bundle typings and add setup docs~~ feat: typescript typings and example Jan 13, 2020

kevinmarrec suggested changes Jan 13, 2020

View reviewed changes

pi0 requested changes Mar 2, 2020

View reviewed changes

lib/core/middleware.js Show resolved Hide resolved

lib/core/hook.js Outdated Show resolved Hide resolved

NickBolles mentioned this pull request Mar 25, 2020

Fix missing method defintion in nuxtjs__auth DefinitelyTyped/DefinitelyTyped#43380

Merged

9 tasks

NickBolles added 10 commits March 25, 2020 08:49

fix(typings): bundle typings and add setup docs

fd00dd4

feat(examples): add typescript example

5f4ac2f

Fix typings and documentation

0e55b46

use async/await instead of mixing it with promise methods

57bd81f

fix misstype and remove redundent comments

66d2838

fix typescript example

e91a729

fix linting issues

50e535a

fix typescript example

1b7dd24

fix(typings): add onRedirect

235766f

Source: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43380/files

fix(typings): additional updates from @types/nuxtjs__auth

4614e4b

NickBolles force-pushed the dev branch from c30452c to 4614e4b Compare March 25, 2020 14:07

kevinmarrec approved these changes Apr 3, 2020

View reviewed changes

NickBolles requested a review from pi0 April 6, 2020 17:55

JoaoPedroAS51 requested changes Apr 7, 2020

View reviewed changes

types/index.d.ts Outdated Show resolved Hide resolved

types/index.d.ts Outdated Show resolved Hide resolved

types/index.d.ts Outdated Show resolved Hide resolved

examples/with-typescript/pages/secure.vue Outdated Show resolved Hide resolved

types/index.d.ts Show resolved Hide resolved

NickBolles added 2 commits April 8, 2020 20:35

updates for token refactor

98ffd53

update examples with new token api

516e94d

NickBolles added 2 commits April 14, 2020 09:01

add refreshController and requestHandler types

dbcebe2

break out types to seperate files

488595a

NickBolles requested a review from JoaoPedroAS51 April 14, 2020 14:02

JoaoPedroAS51 requested changes Apr 14, 2020

View reviewed changes

tpscrpt added a commit to tpscrpt/auth-module that referenced this pull request Apr 18, 2020

fix(nuxt-community#486): type $auth Auth

adc9fe7

tpscrpt added a commit to tpscrpt/auth-module that referenced this pull request Apr 18, 2020

fix(nuxt-community#486): type $auth as Auth in RequestHandler

4c40756

tpscrpt added a commit to tpscrpt/auth-module that referenced this pull request Apr 18, 2020

fix(nuxt-community#486): import Auth type in other files which use it

bf525a8

Also, import @nuxt/auth relatively in the typescript example's package.json

tpscrpt mentioned this pull request Apr 18, 2020

feat: typescript typings and example #622

Closed

NickBolles closed this Apr 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: typescript typings and example #486

feat: typescript typings and example #486

NickBolles commented Nov 20, 2019

codecov bot commented Nov 20, 2019 •

edited

Loading

NickBolles commented Nov 20, 2019

NickBolles commented Dec 7, 2019

davidlandais commented Dec 20, 2019

pi0 left a comment

NickBolles commented Jan 20, 2020

NickBolles commented Feb 4, 2020

NickBolles commented Feb 4, 2020 •

edited

Loading

localhost5001 commented Feb 27, 2020

pi0 left a comment

NickBolles commented Mar 25, 2020

kevinmarrec left a comment •

edited

Loading

JoaoPedroAS51 left a comment

NickBolles commented Apr 9, 2020 •

edited

Loading

t-eckert commented Apr 12, 2020

JoaoPedroAS51 left a comment

JoaoPedroAS51 Apr 14, 2020

NickBolles commented Apr 19, 2020

pi0 commented Apr 21, 2020

NickBolles commented Apr 21, 2020

JoaoPedroAS51 commented Apr 21, 2020

NickBolles commented Apr 21, 2020

feat: typescript typings and example #486

feat: typescript typings and example #486

Conversation

NickBolles commented Nov 20, 2019

codecov bot commented Nov 20, 2019 • edited Loading

Codecov Report

NickBolles commented Nov 20, 2019

NickBolles commented Dec 7, 2019

davidlandais commented Dec 20, 2019

pi0 left a comment

Choose a reason for hiding this comment

NickBolles commented Jan 20, 2020

NickBolles commented Feb 4, 2020

NickBolles commented Feb 4, 2020 • edited Loading

localhost5001 commented Feb 27, 2020

pi0 left a comment

Choose a reason for hiding this comment

NickBolles commented Mar 25, 2020

kevinmarrec left a comment • edited Loading

Choose a reason for hiding this comment

JoaoPedroAS51 left a comment

Choose a reason for hiding this comment

NickBolles commented Apr 9, 2020 • edited Loading

t-eckert commented Apr 12, 2020

JoaoPedroAS51 left a comment

Choose a reason for hiding this comment

JoaoPedroAS51 Apr 14, 2020

Choose a reason for hiding this comment

NickBolles commented Apr 19, 2020

pi0 commented Apr 21, 2020

NickBolles commented Apr 21, 2020

JoaoPedroAS51 commented Apr 21, 2020

NickBolles commented Apr 21, 2020

codecov bot commented Nov 20, 2019 •

edited

Loading

NickBolles commented Feb 4, 2020 •

edited

Loading

kevinmarrec left a comment •

edited

Loading

NickBolles commented Apr 9, 2020 •

edited

Loading